fix: Fix nested pagination/filtering/ordering not working when "only optimization" is disabled #569
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aprams
commented
Jun 29, 2024
strawberry_django/optimizer.py
Outdated
| @@ -1055,7 +1055,7 @@ class DjangoOptimizerExtension(SchemaExtension): | |||
| def __init__( | |||
| self, | |||
| *, | |||
| enable_only_optimization: bool = True, | |||
| enable_only_optimization: bool = False, | |||
There was a problem hiding this comment.
Changed this here as I didn't find an easy way to do it from the test itself.
If the only optimization is True, the test works as expected!
|
Thanks @aprams :) I think I found the issue, going to use this PR to send the fix |
bellini666
changed the title
bellini666
approved these changes
Jun 30, 2024
|
@bellini666 this worked! 🚀 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Types of Changes
Issues Fixed or Closed by This PR
Fix #563
Checklist