fix(optimizer): Avoid extra queries for prefetches with existing prefetch hints

[bellini666]

Fix #559

Summary by Sourcery

This pull request addresses a bug where prefetching with existing prefetch hints resulted in extra database queries. It includes a new test to verify the fix and updates the optimizer to skip unnecessary optimizations in such cases.

• Bug Fixes:
  • Fixed an issue where prefetching with existing prefetch hints caused extra database queries.
• Enhancements:
  • Updated the optimizer to skip optimization when a field has prefetch_related, preventing extra unused queries.
• Tests:
  • Added a test to ensure that prefetch hints with fields having the same name as the model do not cause extra database queries.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request addresses issue #559 by adding a new test to ensure that prefetch hints with fields having the same name as the model do not cause extra database queries. The optimizer was modified to skip optimization when prefetch_related is present in the field's store, preventing extra unused queries. Additionally, the assert_num_queries utility was updated to handle async cases more gracefully.

File-Level Changes

Files	Changes
tests/test_optimizer.py strawberry_django/optimizer.py	Added a new test to ensure prefetch hints with fields having the same name as the model do not cause extra DB queries and modified the optimizer to skip optimization when prefetch_related is present in the field's store.

---

Tips

• Trigger a new Sourcery review by commenting @sourcery-ai review on the pull request.
• Continue your discussion with Sourcery by replying directly to review comments.
• You can change your review settings at any time by accessing your dashboard:
  • Enable or disable the Sourcery-generated pull request summary or reviewer's guide;
  • Change the review language;
• You can always contact us if you have any questions or feedback.

[sourcery-ai]

Hey @bellini666 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟡 General issues: 3 issues found
• 🟢 Security: all looks good
• 🟡 Testing: 5 issues found
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.}

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 66.66667% with 1 line in your changes missing coverage. Please review.

Project coverage is 88.79%. Comparing base (c7c50e9) to head (867e918).

Files	Patch %	Lines
strawberry_django/optimizer.py	66.66%	1 Missing ⚠️

Additional details and impacted files

@@            Coverage Diff             @@
##             main     #582      +/-   ##
==========================================
- Coverage   88.90%   88.79%   -0.11%     
==========================================
  Files          41       41              
  Lines        3595     3598       +3     
==========================================
- Hits         3196     3195       -1     
- Misses        399      403       +4     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.