ignore PLC0105 as well

strawberry-graphql · Jan 4, 2025 · 28a6ecb · 28a6ecb
1 parent 819706c
commit 28a6ecb
Show file tree

Hide file tree

Showing 4 changed files with 8 additions and 5 deletions.
diff --git a/pyproject.toml b/pyproject.toml
@@ -275,6 +275,9 @@ ignore = [
     "PLR0912",
     "PLR0911",
 
+    # Do not force adding _co to covariant typevars
+    "PLC0105",
+
     # Allow private access to attributes
     "SLF001",
 

diff --git a/strawberry/http/typevars.py b/strawberry/http/typevars.py
@@ -1,6 +1,6 @@
 from typing_extensions import TypeVar
 
-Request = TypeVar("Request", contravariant=True)  # noqa: PLC0105
+Request = TypeVar("Request", contravariant=True)
 Response = TypeVar("Response")
 SubResponse = TypeVar("SubResponse")
 WebSocketRequest = TypeVar("WebSocketRequest")

diff --git a/strawberry/schema/schema_converter.py b/strawberry/schema/schema_converter.py
@@ -90,7 +90,7 @@
     from strawberry.types.scalar import ScalarDefinition
 
 
-FieldType = TypeVar(  # noqa: PLC0105
+FieldType = TypeVar(
     "FieldType",
     bound=Union[GraphQLField, GraphQLInputField],
     covariant=True,

diff --git a/tests/experimental/pydantic/test_conversion.py b/tests/experimental/pydantic/test_conversion.py
@@ -1257,10 +1257,10 @@ class User:
     assert user == User(work=[Work(name="developer"), Work(name="tester")])
 
 
-SI_co = TypeVar("SI_co", covariant=True)  # pragma: no mutate
+SI = TypeVar("SI", covariant=True)  # pragma: no mutate
 
 
-class SpecialList(list[SI_co]):
+class SpecialList(list[SI]):
     pass
 
 
@@ -1269,7 +1269,7 @@ def test_can_convert_pydantic_type_to_strawberry_with_specialized_list():
     class WorkModel(BaseModel):
         name: str
 
-    class WorkList(SpecialList[SI_co]):
+    class WorkList(SpecialList[SI]):
         min_items = 1
 
     class UserModel(BaseModel):