Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: deprecate starlite integration. closes #3359 #3492

Merged
merged 6 commits into from
May 11, 2024

Conversation

Birdi7
Copy link
Contributor

@Birdi7 Birdi7 commented May 8, 2024

This PR deprecates the Starlite integration, as stated by issue

Description

  1. Mark starlite.make_graphql_controller function as deprecated
  2. Mark starlite.StarliteRequestAdapter as deprecated class
  3. Add test for both messages

Types of Changes

  • Core
  • Bugfix
  • New feature
  • Enhancement/optimization
  • Documentation

Issues Fixed or Closed by This PR

Closes #3359

Checklist

  • My code follows the code style of this project.
  • My change requires a change to the documentation.
  • I have updated the documentation accordingly.
  • I have read the CONTRIBUTING document.
  • I have added tests to cover my changes.
  • I have tested the changes and verified that they work and don't break anything (as well as I can manage).

@botberry
Copy link
Member

botberry commented May 8, 2024

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:


Deprecations: This release deprecates the Starlite integration in favour of the LiteStar integration.
Refer to the LiteStar integration for more information.
LiteStar is a renamed and upgraded version of Starlite.

Before:

from strawberry.starlite import make_graphql_controller

After:

from strawberry.litestar import make_graphql_controller

Here's the tweet text:

🆕 Release (next) is out! Thanks to Egor for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

Copy link
Contributor

@sourcery-ai sourcery-ai bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Hey @Birdi7 - I've reviewed your changes and they look great!

Here's what I looked at during the review
  • 🟡 General issues: 3 issues found
  • 🟢 Security: all looks good
  • 🟡 Testing: 1 issue found
  • 🟢 Complexity: all looks good

Sourcery is free for open source - if you like our reviews please consider sharing them ✨
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.

strawberry/starlite/controller.py Outdated Show resolved Hide resolved
docs/types/scalars.md Outdated Show resolved Hide resolved
docs/index.md Outdated Show resolved Hide resolved
tests/starlite/test_context.py Show resolved Hide resolved
@Birdi7 Birdi7 force-pushed the fix-issue-3359 branch 2 times, most recently from fcd8b53 to 82dd811 Compare May 8, 2024 22:15
@Birdi7
Copy link
Contributor Author

Birdi7 commented May 8, 2024

@erikwrede would be glad to get your review on this!

Copy link
Member

@patrick91 patrick91 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This is great! Thank you!

Copy link

codecov bot commented May 11, 2024

Codecov Report

Attention: Patch coverage is 80.00000% with 3 lines in your changes are missing coverage. Please review.

Project coverage is 96.48%. Comparing base (9500eab) to head (2554143).

Additional details and impacted files
@@            Coverage Diff             @@
##             main    #3492      +/-   ##
==========================================
+ Coverage   96.23%   96.48%   +0.25%     
==========================================
  Files         510      510              
  Lines       32818    32833      +15     
  Branches     5445     5451       +6     
==========================================
+ Hits        31583    31680      +97     
+ Misses        984      919      -65     
+ Partials      251      234      -17     

Copy link

codspeed-hq bot commented May 11, 2024

CodSpeed Performance Report

Merging #3492 will not alter performance

Comparing Birdi7:fix-issue-3359 (2554143) with main (9500eab)

Summary

✅ 12 untouched benchmarks

@patrick91 patrick91 merged commit 1ad5fb6 into strawberry-graphql:main May 11, 2024
63 of 64 checks passed
@botberry
Copy link
Member

Thanks for contributing to Strawberry! 🎉 You've been invited to join
the Strawberry GraphQL organisation 😊

You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67

And don't forget to join our discord server: https://strawberry.rocks/discord 🔥

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Deprecate starlite
3 participants