-
-
Notifications
You must be signed in to change notification settings - Fork 543
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: deprecate starlite integration. closes #3359 #3492
Conversation
Thanks for adding the Here's a preview of the changelog: Deprecations: This release deprecates the Before: from strawberry.starlite import make_graphql_controller After: from strawberry.litestar import make_graphql_controller Here's the tweet text:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @Birdi7 - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟡 General issues: 3 issues found
- 🟢 Security: all looks good
- 🟡 Testing: 1 issue found
- 🟢 Complexity: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
test + deprecate class
fcd8b53
to
82dd811
Compare
@erikwrede would be glad to get your review on this! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
This is great! Thank you!
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #3492 +/- ##
==========================================
+ Coverage 96.23% 96.48% +0.25%
==========================================
Files 510 510
Lines 32818 32833 +15
Branches 5445 5451 +6
==========================================
+ Hits 31583 31680 +97
+ Misses 984 919 -65
+ Partials 251 234 -17 |
CodSpeed Performance ReportMerging #3492 will not alter performanceComparing Summary
|
Thanks for contributing to Strawberry! 🎉 You've been invited to join You can also request a free sticker by filling this form: https://forms.gle/dmnfQUPoY5gZbVT67 And don't forget to join our discord server: https://strawberry.rocks/discord 🔥 |
This PR deprecates the Starlite integration, as stated by issue
Description
starlite.make_graphql_controller
function as deprecatedstarlite.StarliteRequestAdapter
as deprecated classTypes of Changes
Issues Fixed or Closed by This PR
Closes #3359
Checklist