-
-
Notifications
You must be signed in to change notification settings - Fork 544
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Fix the asgi handler's scope argument type #3581
Fix the asgi handler's scope argument type #3581
Conversation
Reviewer's Guide by SourceryThis pull request addresses a type error in the ASGI handler by changing the 'scope' argument type from 'Request' to 'Scope'. Additionally, it removes unnecessary 'type: ignore' comments and adds a new release notes file to document the patch. File-Level Changes
Tips
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hey @DoctorJohn - I've reviewed your changes and they look great!
Here's what I looked at during the review
- 🟢 General issues: all looks good
- 🟢 Security: all looks good
- 🟢 Testing: all looks good
- 🟡 Complexity: 1 issue found
- 🟢 Documentation: all looks good
Help me be more useful! Please click 👍 or 👎 on each comment to tell me if it was helpful.
Thanks for adding the Here's a preview of the changelog: This release fixes the type of the ASGI request handler's Here's the tweet text:
|
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #3581 +/- ##
==========================================
- Coverage 96.58% 93.86% -2.72%
==========================================
Files 526 522 -4
Lines 34028 32872 -1156
Branches 5624 3750 -1874
==========================================
- Hits 32865 30856 -2009
- Misses 926 1719 +793
- Partials 237 297 +60 |
CodSpeed Performance ReportMerging #3581 will not alter performanceComparing Summary
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Noice!
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks!
Description
This PR fixes a little type error I stumbled across while working on something unrelated. Didn't want to forget about it.
@patrick91 I believe this was accidentally done in #3546? Am I missing something here?
Types of Changes
Summary by Sourcery
This pull request fixes a type error in the ASGI request handler by correcting the type of the
scope
argument. Additionally, it includes aRELEASE.md
file to document the patch release.scope
argument fromRequest
toScope
.RELEASE.md
file to document the patch release.