Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

make sure _span_holder is reset #3716

Merged
Merged
Show file tree
Hide file tree
Changes from 1 commit
Commits
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 2 additions & 1 deletion strawberry/extensions/tracing/opentelemetry.py
Original file line number Diff line number Diff line change
Expand Up @@ -37,7 +37,7 @@

class OpenTelemetryExtension(SchemaExtension):
_arg_filter: Optional[ArgFilter]
_span_holder: Dict[LifecycleStep, Span] = dict()
_span_holder: Dict[LifecycleStep, Span]
_tracer: Tracer

def __init__(
Expand All @@ -48,6 +48,7 @@ def __init__(
) -> None:
self._arg_filter = arg_filter
self._tracer = trace.get_tracer("strawberry")
self._span_holder = dict()
if execution_context:
self.execution_context = execution_context

Expand Down
24 changes: 24 additions & 0 deletions tests/extensions/tracing/test_opentelemetry.py
Original file line number Diff line number Diff line change
@@ -0,0 +1,24 @@
from unittest.mock import Mock

from opentelemetry.trace import Span

from strawberry.extensions import LifecycleStep
from strawberry.extensions.tracing.opentelemetry import (
OpenTelemetryExtension,
OpenTelemetryExtensionSync,
)


def test_span_holder_initialization():
extension = OpenTelemetryExtension()
assert extension._span_holder == {}
extension._span_holder[LifecycleStep.OPERATION] = Mock(spec=Span)
extension = OpenTelemetryExtension()
assert extension._span_holder == {}

def test_span_holder_initialization_sync():
extension = OpenTelemetryExtensionSync()
assert extension._span_holder == {}
extension._span_holder[LifecycleStep.OPERATION] = Mock(spec=Span)
extension = OpenTelemetryExtensionSync()
assert extension._span_holder == {}
Loading