Add default values to Context and RootValue type vars

[patrick91]

Closes #2711

Summary by Sourcery

Set default values for the Context and RootValue type variables to None.

New Features:

• Add default values to Context and RootValue type variables.

Enhancements:

• Remove unnecessary type parameters from GraphQLRouter instantiation.

[sourcery-ai]

Reviewer's Guide by Sourcery

This pull request adds default values to the Context and RootValue type variables in strawberry.http.typevars.py. This addresses a typing issue and makes the code more robust by providing default values for these type variables. The changes were made by modifying the TypeVar declarations for Context and RootValue to include default=None.

Class diagram showing updated TypeVar definitions

classDiagram
    class TypeVars {
        +Request: TypeVar[contravariant=True]
        +Response: TypeVar
        +SubResponse: TypeVar
        +WebSocketRequest: TypeVar
        +WebSocketResponse: TypeVar
        +Context: TypeVar[default=None]
        +RootValue: TypeVar[default=None]
    }
    note for TypeVars "Context and RootValue now have default=None"

Loading

File-Level Changes

Change	Details	Files
Added default values to the typevars	Added default=None to the TypeVar declarations for Context and RootValue. Imported TypeVar from typing_extensions instead of typing. Reordered the __all__ list to maintain alphabetical order.	strawberry/http/typevars.py
Updated usages of typevars	Removed explicit type variable declarations from GraphQLRouter instances, allowing the default values to be used.	tests/fastapi/test_context.py

Assessment against linked issues

Issue	Objective	Addressed	Explanation
#2711	Fix mypy type annotation error for 'graphql_app' variable when using strawberry-graphql>=0.169.0	✅

---

Tips and commands

Interacting with Sourcery

• Trigger a new review: Comment @sourcery-ai review on the pull request.
• Continue discussions: Reply directly to Sourcery's review comments.
• Generate a GitHub issue from a review comment: Ask Sourcery to create an
  issue from a review comment by replying to it.
• Generate a pull request title: Write @sourcery-ai anywhere in the pull
  request title to generate a title at any time.
• Generate a pull request summary: Write @sourcery-ai summary anywhere in
  the pull request body to generate a PR summary at any time. You can also use
  this command to specify where the summary should be inserted.

Customizing Your Experience

Access your dashboard to:

• Enable or disable review features such as the Sourcery-generated pull request
  summary, the reviewer's guide, and others.
• Change the review language.
• Add, remove or edit custom review instructions.
• Adjust other review settings.

Getting Help

• Contact our support team for questions or feedback.
• Visit our documentation for detailed guides and information.
• Keep in touch with the Sourcery team by following us on X/Twitter, LinkedIn or GitHub.

[sourcery-ai]

Hey @patrick91 - I've reviewed your changes and they look great!

Here's what I looked at during the review

• 🟢 General issues: all looks good
• 🟢 Security: all looks good
• 🟢 Testing: all looks good
• 🟢 Complexity: all looks good
• 🟢 Documentation: all looks good

---

Sourcery is free for open source - if you like our reviews please consider sharing them ✨

• X
• Mastodon
• LinkedIn
• Facebook

_{Help me be more useful! Please click 👍 or 👎 on each comment and I'll use the feedback to improve your reviews.}

[botberry]

Thanks for adding the RELEASE.md file!

Here's a preview of the changelog:

---

This release updates the Context and RootValue vars to have
a default value of None, this makes it easier to use the views
without having to pass in a value for these vars.

Here's the tweet text:

🆕 Release (next) is out! Thanks to @patrick91 for the PR 👏

Get it here 👉 https://strawberry.rocks/release/(next)

[codecov]

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 96.97%. Comparing base (633c9bc) to head (8f09415).
Report is 1 commits behind head on main.

Additional details and impacted files

@@           Coverage Diff           @@
##             main    #3732   +/-   ##
=======================================
  Coverage   96.97%   96.97%           
=======================================
  Files         503      503           
  Lines       33702    33708    +6     
  Branches     5627     5627           
=======================================
+ Hits        32683    32689    +6     
  Misses        809      809           
  Partials      210      210           

[codspeed-hq]

CodSpeed Performance Report

Merging #3732 will not alter performance

_{Comparing feature/default-vars (8f09415) with main (633c9bc)}

Summary

✅ 21 untouched benchmarks

[botberry]

Apollo Federation Subgraph Compatibility Results

Federation 1 Support	Federation 2 Support
_service 🟢 @key (single) 🟢 @key (multi) 🟢 @key (composite) 🟢 repeatable @key 🟢 @requires 🟢 @provides 🟢 federated tracing 🔲	@link 🟢 @shareable 🟢 @tag 🟢 @override 🟢 @inaccessible 🟢 @composeDirective 🟢 @interfaceObject 🟢

Learn more:

• Apollo Federation Subgraph Specification
• Compatibility Tests