Skip to content

Commit

Permalink
Merge branch 'master' into preview
Browse files Browse the repository at this point in the history
  • Loading branch information
SLOBS-Release committed Jan 16, 2025
2 parents 5cc92b8 + 8110c7e commit ba1d744
Show file tree
Hide file tree
Showing 2 changed files with 4 additions and 18 deletions.
4 changes: 3 additions & 1 deletion app/components-react/pages/BrowseOverlays.tsx
Original file line number Diff line number Diff line change
Expand Up @@ -172,7 +172,9 @@ export default function BrowseOverlays(p: {
}

const sourceSettings =
type === 'video' ? { looping: true, local_file: localFile } : { file: localFile };
type === 'video'
? { looping: true, local_file: localFile, display: 'horizontal' }
: { file: localFile, display: 'horizontal' };

return ScenesService.actions.return.createAndAddSource(
sceneId,
Expand Down
18 changes: 1 addition & 17 deletions app/services/scenes/scenes.ts
Original file line number Diff line number Diff line change
Expand Up @@ -460,28 +460,12 @@ export class ScenesService extends StatefulService<IScenesState> {

const sceneItem = scene.createAndAddSource(sourceName, sourceType, settings);

const createVerticalNode = () => {
if (this.dualOutputService.views.hasSceneNodeMaps) {
this.dualOutputService.createPartnerNode(sceneItem);
/* For some reason dragging items after enabling dual output makes them
* duplicate, associate selection on switch to mitigate this issue
*/
this.selectionService.associateSelectionWithDisplay('vertical');
};

if (this.dualOutputService.state.dualOutputMode) {
createVerticalNode();
} else {
// Schedule vertical node to be created if the user toggles on dual output in the same session
this.dualOutputService.dualOutputModeChanged
.pipe(
// If we switch collections before we enable dual output drop it
// we don't wanna create nodes on inactive scene collections
takeUntil(this.sceneCollectionsService.collectionWillSwitch),
filter(gotEnabled => !!gotEnabled),
take(1),
tap(createVerticalNode),
)
.subscribe();
}

return sceneItem.sceneItemId;
Expand Down

0 comments on commit ba1d744

Please sign in to comment.