feat: Enhance ID3 Support: Implement APIC Functionality #76
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
fernandocQualabs
force-pushed
the
feature/add-shaka-unit-tests-into-cml
branch
from
bd8655c to
6a0d499
Compare
littlespex
reviewed
Feb 27, 2024
Signed-off-by: Fernando Cuadro <[email protected]>
Signed-off-by: Fernando Cuadro <[email protected]>
Signed-off-by: Fernando Cuadro <[email protected]>
Signed-off-by: Fernando Cuadro <[email protected]>
Signed-off-by: Fernando Cuadro <[email protected]>
Signed-off-by: Fernando Cuadro <[email protected]>
Signed-off-by: Felipe Young <[email protected]> Signed-off-by: Fernando Cuadro <[email protected]>
Signed-off-by: Fernando Cuadro <[email protected]>
Signed-off-by: Fernando Cuadro <[email protected]>
Signed-off-by: Fernando Cuadro <[email protected]>
Signed-off-by: Fernando Cuadro <[email protected]>
fernandocQualabs
force-pushed
the
feature/add-shaka-unit-tests-into-cml
branch
from
8fe09da to
e122690
Compare
fernandocQualabs
changed the title
Signed-off-by: hernan <[email protected]>
littlespex
requested changes
Feb 27, 2024
…liance#76 Signed-off-by: Fernando Cuadro <[email protected]>
Signed-off-by: Fernando Cuadro <[email protected]>
felipeYoungi
previously approved these changes
Feb 28, 2024
littlespex
requested changes
Feb 28, 2024
Signed-off-by: Fernando Cuadro <[email protected]>
Signed-off-by: Felipe Young <[email protected]>
littlespex
requested changes
Feb 28, 2024
felipeYoungi
previously approved these changes
Feb 29, 2024
Signed-off-by: Fernando Cuadro <[email protected]>
littlespex
previously approved these changes
Feb 29, 2024
Signed-off-by: fernandocQualabs <[email protected]>
littlespex
approved these changes
Feb 29, 2024
felipeYoungi
approved these changes
Feb 29, 2024
littlespex
merged commit c8024a9
into
streaming-video-technology-alliance:release/0.6.3
2 checks passed
littlespex
pushed a commit
that referenced
this pull request
Feb 29, 2024
* added APIC frame parser --------- Signed-off-by: Fernando Cuadro <[email protected]> Signed-off-by: Felipe Young <[email protected]> Signed-off-by: hernan <[email protected]> Signed-off-by: fernandocQualabs <[email protected]> Co-authored-by: Felipe Young <[email protected]> Co-authored-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>
littlespex
added a commit
that referenced
this pull request
Feb 29, 2024
* chore: update version to 0.6.3 * feat: Enhance ID3 Support: Implement APIC Functionality (#76) * chore: update @web/dev-server to address dependabot security issue (#79) --------- Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Fernando Cuadro <[email protected]> Signed-off-by: Felipe Young <[email protected]> Signed-off-by: hernan <[email protected]> Signed-off-by: fernandocQualabs <[email protected]> Co-authored-by: fernandocQualabs <[email protected]> Co-authored-by: Felipe Young <[email protected]> Co-authored-by: hernan <[email protected]>
littlespex
added a commit
to qualabs/common-media-library
that referenced
this pull request
Apr 5, 2024
* chore: update version to 0.6.3 * feat: Enhance ID3 Support: Implement APIC Functionality (streaming-video-technology-alliance#76) * chore: update @web/dev-server to address dependabot security issue (streaming-video-technology-alliance#79) --------- Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Fernando Cuadro <[email protected]> Signed-off-by: Felipe Young <[email protected]> Signed-off-by: hernan <[email protected]> Signed-off-by: fernandocQualabs <[email protected]> Co-authored-by: fernandocQualabs <[email protected]> Co-authored-by: Felipe Young <[email protected]> Co-authored-by: hernan <[email protected]>
littlespex
added a commit
to qualabs/common-media-library
that referenced
this pull request
Apr 5, 2024
* chore: update version to 0.6.3 * feat: Enhance ID3 Support: Implement APIC Functionality (streaming-video-technology-alliance#76) * chore: update @web/dev-server to address dependabot security issue (streaming-video-technology-alliance#79) --------- Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Fernando Cuadro <[email protected]> Signed-off-by: Felipe Young <[email protected]> Signed-off-by: hernan <[email protected]> Signed-off-by: fernandocQualabs <[email protected]> Co-authored-by: fernandocQualabs <[email protected]> Co-authored-by: Felipe Young <[email protected]> Co-authored-by: hernan <[email protected]> Signed-off-by: Casey Occhialini <[email protected]>
littlespex
added a commit
to qualabs/common-media-library
that referenced
this pull request
Apr 5, 2024
* chore: update version to 0.6.3 * feat: Enhance ID3 Support: Implement APIC Functionality (streaming-video-technology-alliance#76) * chore: update @web/dev-server to address dependabot security issue (streaming-video-technology-alliance#79) --------- Signed-off-by: Casey Occhialini <[email protected]> Signed-off-by: Fernando Cuadro <[email protected]> Signed-off-by: Felipe Young <[email protected]> Signed-off-by: hernan <[email protected]> Signed-off-by: fernandocQualabs <[email protected]> Co-authored-by: fernandocQualabs <[email protected]> Co-authored-by: Felipe Young <[email protected]> Co-authored-by: hernan <[email protected]>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added functionality for parsing APIC Id3 frames (id3 with images).
Added Shaka and HLS Id3 unit tests.
Added new unit tests in CML:
-- readId3Size
-- isId3Header
-- isId3Footer
-- decodeId3Frame