store-free output module optimization #330
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sduchesneau
requested changes
Oct 26, 2023
pipeline/resolve.go
Outdated
| @@ -94,6 +106,10 @@ func computeLinearHandoffBlockNum(productionMode bool, startBlock, stopBlock uin | |||
| if err != nil { | |||
| return startBlock, nil | |||
| } | |||
|
|
|||
| if !stateRequired { | |||
There was a problem hiding this comment.
move this to line 105 to avoid computation
colindickson
force-pushed
the
stateless-linear-handoff
branch
from
e754459 to
a67f5f2
Compare
…s in reversible segment and output module does not have any stores in its dependencies
colindickson
force-pushed
the
stateless-linear-handoff
branch
from
a67f5f2 to
0a4289d
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
optimized start of output stream in developer mode when start block is in reversible segment and output module does not have any stores in its dependencies