Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Improve tls authentication for sn-platform #1102

Draft
wants to merge 3 commits into
base: master
Choose a base branch
from

Conversation

tuteng
Copy link
Member

@tuteng tuteng commented Sep 13, 2023

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

components:
  vault: false
  functions: false
  streamnative_console: false
  node_exporter: false

tls:
  enabled: true
  proxy:
    enabled: true
  broker:
    enabled: true

auth:
  authentication:
    tls:
      enabled: true
  authorization:
    enabled: true
  superUsers:
    proxyRolesEnabled: true

vault:
  enabled: false

certs:
  internal_issuer:
    enabled: true

broker:
  kop:
    enabled: false


Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@tuteng tuteng requested review from sijie and a team as code owners September 13, 2023 09:55
@tuteng tuteng marked this pull request as draft September 13, 2023 09:55
@github-actions
Copy link

@tuteng:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Sep 13, 2023
@ericsyh ericsyh modified the milestone: sn-platform-1.11 Sep 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-info-missing This pr needs to mark a document option in description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants