Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[FM v0.6.0]--Update docs for HPA autoscaling enhancement #172

Merged
merged 3 commits into from
Sep 23, 2022
Merged

[FM v0.6.0]--Update docs for HPA autoscaling enhancement #172

merged 3 commits into from
Sep 23, 2022

Conversation

Huanli-Meng
Copy link
Contributor

@Huanli-Meng Huanli-Meng commented Sep 20, 2022 •
edited
Loading

Motivation

Function Mesh v0.6.0 enhanced HAP auto-scaling (code PR #450), therefore add docs accordingly.

Modification

  • Function Mesh v0.6.0
    • Function/Source/Sink CRD configurations
      • Add an item "minReplicas"
    • Scaling:
      • Restructure the doc and add more examples
  • Legacy releases
    • Update typos
    • change kunectl to kubectl
    • change maxReplica to maxReplicas

@Huanli-Meng Huanli-Meng self-assigned this Sep 20, 2022
@Huanli-Meng Huanli-Meng requested review from tuteng and a team as code owners September 20, 2022 03:37
@netlify
Copy link

netlify bot commented Sep 20, 2022 •
edited
Loading

✅ Deploy Preview for function-mesh ready!

Name Link
🔨 Latest commit 6ec38cd
🔍 Latest deploy log https://app.netlify.com/sites/function-mesh/deploys/632c17622eb680000a5abebd
😎 Deploy Preview https://deploy-preview-172--function-mesh.netlify.app
📱 Preview on mobile
Toggle QR Code...

QR Code

Use your smartphone camera to open QR code link.

To edit notification comments on pull requests, go to your Netlify site settings.

tpiperatgod
tpiperatgod previously approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@tpiperatgod tpiperatgod left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

teachwrite
teachwrite previously approved these changes Sep 21, 2022
View reviewed changes
Copy link
Contributor

@teachwrite teachwrite left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I have a few suggestions, mostly word order corrections. Otherwise, this LGTM.

docs/connectors/io-crd-config/sink-crd-config.md Outdated Show resolved Hide resolved
docs/connectors/io-crd-config/sink-crd-config.md Outdated Show resolved Hide resolved
docs/connectors/io-crd-config/source-crd-config.md Outdated Show resolved Hide resolved
docs/connectors/io-crd-config/source-crd-config.md Outdated Show resolved Hide resolved
docs/functions/function-crd.md Outdated Show resolved Hide resolved
versioned_docs/version-0.1.9/scaling.md Outdated Show resolved Hide resolved
versioned_docs/version-0.2.0/scaling.md Outdated Show resolved Hide resolved
versioned_docs/version-0.3.0/scaling.md Outdated Show resolved Hide resolved
versioned_docs/version-0.4.0/scaling.md Outdated Show resolved Hide resolved
versioned_docs/version-0.5.0/scaling.md Outdated Show resolved Hide resolved
@Huanli-Meng Huanli-Meng dismissed stale reviews from teachwrite and tpiperatgod via 3dbef9a September 22, 2022 07:40
@Huanli-Meng
Copy link
Contributor Author

@tpiperatgod I've applied the technical and editorial review comments. Could you please help look into it again and feel free to approve it if there are no more comments? Thanks.

@Huanli-Meng Huanli-Meng merged commit c5cdcc0 into main Sep 23, 2022
@Huanli-Meng Huanli-Meng deleted the hpa-autoscaling branch September 23, 2022 06:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@tpiperatgod tpiperatgod tpiperatgod approved these changes

@teachwrite teachwrite teachwrite left review comments

@tuteng tuteng Awaiting requested review from tuteng tuteng is a code owner

Assignees

@Huanli-Meng Huanli-Meng

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@Huanli-Meng @tpiperatgod @teachwrite