Update subscription get message by id typo lederId to ledgerId #1699
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
@Nikolajls:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
Nikolajls
changed the title
This was referenced Jan 12, 2025
|
@Nikolajls:Thanks for providing doc info! |
github-actions
bot
added
no-need-doc
zymap
approved these changes
Jan 15, 2025
zymap
pushed a commit
that referenced
this pull request
Jan 15, 2025
* Update subscription get message by id typo lederId to edgerId * Adjust after merge, use ledgerID for get message by id (cherry picked from commit b9416b7)
zymap
pushed a commit
that referenced
this pull request
Jan 15, 2025
* Update subscription get message by id typo lederId to edgerId * Adjust after merge, use ledgerID for get message by id (cherry picked from commit b9416b7)
zymap
pushed a commit
that referenced
this pull request
Jan 15, 2025
* Update subscription get message by id typo lederId to edgerId * Adjust after merge, use ledgerID for get message by id (cherry picked from commit b9416b7)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Motivation
A typo problem in ledgerId being named legerId which has given multiple errors when writing CLI arguments.
Modifications
Describe the modifications you've done.
Renaming of it .
Verifying this change
Not sure how to do this so havent done it yet - I've created more information here
Improvement of how to contribute testing, local setup. #1703
Documentation
no-need-doc