Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix code check #1711

Merged
merged 1 commit into from
Jan 16, 2025
Merged

fix code check #1711

merged 1 commit into from
Jan 16, 2025

Conversation

shibd
Copy link
Member

@shibd shibd commented Jan 16, 2025

Motivation

Fix: https://github.com/streamnative/pulsarctl/actions/runs/12785291291/job/35640203336?pr=1710

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@shibd shibd self-assigned this Jan 16, 2025
@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jan 16, 2025
@shibd shibd merged commit 4ac7a7b into master Jan 16, 2025
12 checks passed
@shibd shibd deleted the fix_lint branch January 16, 2025 03:40
shibd added a commit that referenced this pull request Jan 16, 2025
(cherry picked from commit 4ac7a7b)
shibd added a commit that referenced this pull request Jan 16, 2025
(cherry picked from commit 4ac7a7b)
shibd added a commit that referenced this pull request Jan 16, 2025
(cherry picked from commit 4ac7a7b)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants