Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Disable gcp_public_cidrs_access_enabled by default #62

Merged
merged 3 commits into from
Jan 16, 2025
Merged

fix: Disable gcp_public_cidrs_access_enabled by default #62

Show file tree
Hide file tree
Changes from 2 commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
9a9c09c
Disable gcp_public_cidrs_access_enabled by default
ciiiii Jan 16, 2025
483eae9
Fix version
ciiiii Jan 16, 2025
ffddfe7
Update README
ciiiii Jan 16, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
182 changes: 79 additions & 103 deletions examples/root_example/.terraform.lock.hcl
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

6 changes: 1 addition & 5 deletions examples/root_example/main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -17,12 +17,8 @@ terraform {

required_providers {
google = {
version = ">=4.60.0"
source = "hashicorp/google"
version = "~>5.19"
}
google-beta = {
source = "hashicorp/google-beta"
version = "~> 5.19"
}
helm = {
source = "hashicorp/helm"
Expand Down
5 changes: 3 additions & 2 deletions main.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -161,7 +161,7 @@ locals {
module "gke" {
count = var.enable_private_gke ? 0 : 1
source = "terraform-google-modules/kubernetes-engine/google"
version = "30.3.0"
version = "33.1.0"

name = var.cluster_name
add_cluster_firewall_rules = var.add_cluster_firewall_rules
Expand All @@ -182,6 +182,7 @@ module "gke" {
maintenance_exclusions = var.maintenance_exclusions
maintenance_start_time = var.maintenance_window
master_authorized_networks = var.master_authorized_networks
gcp_public_cidrs_access_enabled = var.gcp_public_cidrs_access_enabled
network = var.vpc_network
network_project_id = var.network_project_id
network_policy = var.cluster_network_policy
Expand All @@ -202,7 +203,7 @@ module "gke" {
module "gke_private" {
count = var.enable_private_gke ? 1 : 0
source = "terraform-google-modules/kubernetes-engine/google//modules/private-cluster"
version = "30.3.0"
version = "33.1.0"

name = var.cluster_name
add_cluster_firewall_rules = var.add_cluster_firewall_rules
Expand Down
5 changes: 5 additions & 0 deletions variables.tf
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -454,6 +454,11 @@ variable "master_authorized_networks" {
type = list(object({ cidr_block = string, display_name = string }))
}

variable "gcp_public_cidrs_access_enabled" {
default = false
ciiiii marked this conversation as resolved.
Show resolved Hide resolved
description = "Enable access from GCP public CIDRs. Defaults to false."
}

variable "node_pool_autoscaling" {
default = true
description = "Enable autoscaling of the default node pool. Defaults to \"true\"."
Expand Down
Loading