Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(ci): gpg key in the release action #113

Merged
merged 1 commit into from
Jan 11, 2024
Merged

fix(ci): gpg key in the release action #113

merged 1 commit into from
Jan 11, 2024

Conversation

maxsxu
Copy link
Member

@maxsxu maxsxu commented Jan 11, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@maxsxu maxsxu requested review from tuteng and labuladong January 11, 2024 04:01
@maxsxu maxsxu self-assigned this Jan 11, 2024
@maxsxu maxsxu requested a review from a team as a code owner January 11, 2024 04:01
Copy link

@maxsxu:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added doc-info-missing This pr needs to mark a document option in description and removed doc-info-missing This pr needs to mark a document option in description labels Jan 11, 2024
Copy link

@maxsxu:Thanks for providing doc info!

@github-actions github-actions bot added the no-need-doc This pr does not need any document label Jan 11, 2024
@maxsxu maxsxu merged commit 9d28584 into master Jan 11, 2024
5 checks passed
@maxsxu maxsxu deleted the max/fix-gpg-key branch January 11, 2024 04:38
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
no-need-doc This pr does not need any document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants