-
Notifications
You must be signed in to change notification settings - Fork 36
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
force functions and connector using v3 api admin client #126
Merged
illegalnumbers
merged 9 commits into
master
from
freeznet/force-functions-connector-using-v3
Oct 1, 2024
Merged
force functions and connector using v3 api admin client #126
illegalnumbers
merged 9 commits into
master
from
freeznet/force-functions-connector-using-v3
Oct 1, 2024
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
@freeznet:Thanks for your contribution. For this PR, do we need to update docs? |
github-actions
bot
added
the
doc-info-missing
This pr needs to mark a document option in description
label
Sep 29, 2024
github-actions
bot
removed
the
doc-info-missing
This pr needs to mark a document option in description
label
Sep 29, 2024
@freeznet:Thanks for providing doc info! |
nlu90
previously approved these changes
Sep 30, 2024
nlu90
approved these changes
Sep 30, 2024
jiangpengcheng
approved these changes
Sep 30, 2024
illegalnumbers
approved these changes
Sep 30, 2024
ciiiii
approved these changes
Oct 1, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
(If this PR fixes a github issue, please add
Fixes #<xyz>
.)Fixes #
(or if this PR is one task of a github issue, please add
Master Issue: #<xyz>
to link to the master issue.)Master Issue: #
Motivation
For functions and connectors user, they will need to set
api_version
tov3
when managing pulsar functions and connectors. But once the api_version set to v3, there is no way to manage other pulsar resources like tenants, because those resources are using v2 apis.This PR forces the functions and connectors using v3 API, at the same time, it will fall-back to v2 if accessing other resources apis. To make the pulsar provider works for all admin apis at the same provider instance.
Modifications
Describe the modifications you've done.
Verifying this change
(Please pick either of the following options)
This change is a trivial rework / code cleanup without any test coverage.
(or)
This change is already covered by existing tests, such as (please describe tests).
(or)
This change added tests and can be verified as follows:
(example:)
Documentation
Check the box below.
Need to update docs?
doc-required
(If you need help on updating docs, create a doc issue)
no-need-doc
(Please explain why)
doc
(If this PR contains doc changes)