Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

force functions and connector using v3 api admin client #126

Merged
merged 9 commits into from
Oct 1, 2024

Conversation

freeznet
Copy link
Member

@freeznet freeznet commented Sep 29, 2024

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

For functions and connectors user, they will need to set api_version to v3 when managing pulsar functions and connectors. But once the api_version set to v3, there is no way to manage other pulsar resources like tenants, because those resources are using v2 apis.
This PR forces the functions and connectors using v3 API, at the same time, it will fall-back to v2 if accessing other resources apis. To make the pulsar provider works for all admin apis at the same provider instance.

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet self-assigned this Sep 29, 2024
@freeznet freeznet requested a review from a team as a code owner September 29, 2024 05:40
Copy link

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Sep 29, 2024
@github-actions github-actions bot removed the doc-info-missing This pr needs to mark a document option in description label Sep 29, 2024
Copy link

@freeznet:Thanks for providing doc info!

@github-actions github-actions bot added the doc This pr contains a document label Sep 29, 2024
nlu90
nlu90 previously approved these changes Sep 30, 2024
@freeznet freeznet requested a review from nlu90 September 30, 2024 03:39
@illegalnumbers illegalnumbers merged commit 96d1e22 into master Oct 1, 2024
2 checks passed
@illegalnumbers illegalnumbers deleted the freeznet/force-functions-connector-using-v3 branch October 1, 2024 22:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc This pr contains a document
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants