Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix namespace config drift #137

Merged
merged 9 commits into from
Jan 10, 2025
Merged

Conversation

freeznet
Copy link
Member

@freeznet freeznet commented Jan 8, 2025

(If this PR fixes a github issue, please add Fixes #<xyz>.)

Fixes #

(or if this PR is one task of a github issue, please add Master Issue: #<xyz> to link to the master issue.)

Master Issue: #

Motivation

Explain here the context, and why you're making that change. What is the problem you're trying to solve.

Similar to hashicorp/terraform-plugin-sdk#123

Modifications

Describe the modifications you've done.

Verifying this change

  • Make sure that the change passes the CI checks.

(Please pick either of the following options)

This change is a trivial rework / code cleanup without any test coverage.

(or)

This change is already covered by existing tests, such as (please describe tests).

(or)

This change added tests and can be verified as follows:

(example:)

  • Added integration tests for end-to-end deployment with large payloads (10MB)
  • Extended integration test for recovery after broker failure

Documentation

Check the box below.

Need to update docs?

  • doc-required

    (If you need help on updating docs, create a doc issue)

  • no-need-doc

    (Please explain why)

  • doc

    (If this PR contains doc changes)

@freeznet freeznet self-assigned this Jan 8, 2025
@freeznet freeznet requested a review from a team as a code owner January 8, 2025 06:26
Copy link

github-actions bot commented Jan 8, 2025

@freeznet:Thanks for your contribution. For this PR, do we need to update docs?
(The PR template contains info about doc, which helps others know more about the changes. Can you provide doc-related info in this and future PR descriptions? Thanks)

@github-actions github-actions bot added the doc-info-missing This pr needs to mark a document option in description label Jan 8, 2025
@freeznet freeznet merged commit 8dac191 into master Jan 10, 2025
3 checks passed
@freeznet freeznet deleted the freeznet/fix-namespace-config-drift branch January 10, 2025 02:31
@langesven
Copy link

langesven commented Jan 15, 2025

I might be mistaken but this appears to introduce a change of default values that have a different meaning than previously.

This change changes the default for offload_threshold_size_in_mb from -1 to 0.

From the 3.0.x docs

Maximum number of bytes stored in the pulsar cluster for a topic before data will start being automatically offloaded to longterm storage (eg: 10M, 16G, 3T, 100).
-1 falls back to the cluster’s namespace default.
Negative values disable automatic offload.
0 triggers offloading as soon as possible

So with this change now wanting to switch all offload_threshold_size_in_mb if not defined from -1 (disabled) to 0 (offload as soon as possible) is a 180 on previous behaviour.

The docs for 4.0.x are missing the explanation, but it's visible in the source code at least as well as the default being -1

Additionally due to validateGtEq0 being used it's not possible to still actively set a value of -1

Error: "namespace_config.0.offload_threshold_size_in_mb" must be 0 or more, got: -1

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
doc-info-missing This pr needs to mark a document option in description
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants