feat: added Default Quality/Bitrate #24
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
topiga
changed the title
topiga
commented
Feb 10, 2025
|
|
||
| public enum Bitrates | ||
| { | ||
| Max = undefined, |
There was a problem hiding this comment.
I'm not sure if this works. The "Max" bitrate is undefined on Streamyfin, but JavaScript and C# are two completely different languages...
There was a problem hiding this comment.
you can run dotnet build to see if its valid. but for int enums 0 should generally be whats used to represent a 'undefined' value
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Complements streamyfin/streamyfin#509
I don't know if this is good, I have no idea how to test it. Please tell me if I need to change something.