Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

synchronize more on quest visibility updates #6111

Merged
merged 1 commit into from
Jan 29, 2025
Merged

synchronize more on quest visibility updates #6111

merged 1 commit into from
Jan 29, 2025

Conversation

westnordost
Copy link
Member

fixes #5545

@westnordost westnordost requested a review from Helium314 January 27, 2025 21:48
@Helium314
Copy link
Collaborator

Looks good!
Though now I'm pondering whether it would also be a problem if onUpdated overtakes onReplacedForBbox while quests for the bbox are being created. Anyway, this is not what happened in the log provided in #5545 (comment)

@westnordost
Copy link
Member Author

Ehm, which class?

@Helium314
Copy link
Collaborator

OsmQuestController.mapDataSourceListener
If we assume persisting elements is done, and onReplacedForBBox is called, then could it be bad if onUpdated if called while onReplacedForBBox is in createQuestsForBBox?
But maybe we should just work on problems that actually occurred, and think about this only if the quest-asked-again issue comes up again.

@westnordost
Copy link
Member Author

I think this is covered by the fact that the MapDataWithElementsSource will replay any updates done while replacing the bbox.

@westnordost westnordost merged commit 8e6fea3 into master Jan 29, 2025
@FloEdelmann FloEdelmann deleted the fix-5545 branch January 29, 2025 22:51
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

House number quest is asked again immediately after solving it
2 participants