Disable IPV6 since not supported by PlayStation network now + Only fr…

…ee message if not already freed by failure when REGIST or session doesn't finish
streetpea · Oct 16, 2024 · 2344da0 · 2344da0
1 parent 80aa54b
commit 2344da0
Show file tree

Hide file tree

Showing 3 changed files with 6 additions and 7 deletions.
diff --git a/lib/src/regist.c b/lib/src/regist.c
@@ -649,10 +649,9 @@ static ChiakiErrorCode regist_recv_response(ChiakiRegist *regist, ChiakiRegister
 		RudpMessage message;
 		err = chiaki_rudp_send_recv(regist->info.rudp, &message, NULL, 0, remote_counter, ACK, FINISH, 0, 3);
 		if(err != CHIAKI_ERR_SUCCESS)
-		{
 			CHIAKI_LOGW(regist->log, "REGIST - Failed to finish rudp, continuing...");
-		}
-		chiaki_rudp_message_pointers_free(&message);
+		else
+			chiaki_rudp_message_pointers_free(&message);
 	}
 
 	CHIAKI_LOGV(regist->log, "Regist response HTTP header:");

diff --git a/lib/src/remote/holepunch.c b/lib/src/remote/holepunch.c
@@ -77,6 +77,7 @@
 #define MSG_TYPE_REQ 0x06000000
 #define MSG_TYPE_RESP 0x07000000
 #define EXTRA_CANDIDATE_ADDRESSES 3
+#define ENABLE_IPV6 false
 
 static const char oauth_header_fmt[] = "Authorization: Bearer %s";
 
@@ -2588,7 +2589,7 @@ static ChiakiErrorCode send_offer(Session *session, int req_id, Candidate *local
             goto cleanup;
         }
         // Only PS5 supports ipv6
-        if(session->console_type == CHIAKI_HOLEPUNCH_CONSOLE_TYPE_PS5)
+        if(session->console_type == CHIAKI_HOLEPUNCH_CONSOLE_TYPE_PS5 && ENABLE_IPV6)
         {
             Candidate *candidate_stun_ipv6 = &msg.conn_request->candidates[msg.conn_request->num_candidates];
             candidate_stun_ipv6->type = CANDIDATE_TYPE_STUN;

diff --git a/lib/src/session.c b/lib/src/session.c
@@ -962,10 +962,9 @@ static ChiakiErrorCode session_thread_request_session(ChiakiSession *session, Ch
 		RudpMessage message;
 		err = chiaki_rudp_send_recv(session->rudp, &message, NULL, 0, remote_counter, ACK, FINISH, 0, 3);
 		if(err != CHIAKI_ERR_SUCCESS)
-		{
 			CHIAKI_LOGW(session->log, "SESSION START THREAD - Failed to finish rudp, continuing...");
-		}
-		chiaki_rudp_message_pointers_free(&message);
+		else
+			chiaki_rudp_message_pointers_free(&message);
 	}
 
 	ChiakiHttpResponse http_response;