[WIP] Base spline support #1287
Draft
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
# Conflicts: # sources/engine/Stride.Engine/Engine/Splines/Components/SplineComponent.cs # sources/engine/Stride.Engine/Engine/Splines/Components/SplineNodeComponent.cs # sources/engine/Stride.Engine/Engine/Splines/Components/SplineTravellerComponent.cs
…decorator # Conflicts: # sources/engine/Stride.Engine/Engine/Splines/Models/SplineNode.cs
…nePR+mesh+decorator
…nePR+mesh+decorator
xen2
reviewed
Jan 8, 2025
| DestroySplineRenderer(null, entity); | ||
| component.Spline.OnSplineDirty -= data.OnSplineDirtyAction; | ||
| entity.Transform.PostOperations.Remove(data.TransformOperation); | ||
| } |
There was a problem hiding this comment.
Probably better to add splineComponentsToUpdate.Remove(component) in case it gets added and removed without a frame running in between (it can happen if components are manually removed after a load, etc.)
| { | ||
| component.SplineComponent.Spline.OnSplineDirty -= data.OnSplineDirtyAction; | ||
| entity.Transform.PostOperations.Remove(data.TransformOperation); | ||
| } |
There was a problem hiding this comment.
Missing splineTraverserComponents.Remove()
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Details
This PR contains basic support for creating splines and visualizing those splines.
Motivation and Context
Splines are useful for camera paths, or any other object that requires bezier curve for movement, generating geometry and for distributing geometry (see prototype video). This first PR should cover the creation and editing of the spline.
Description
(outdate, should make a new one)
For a full overview see this video which is specifically recorded for this PR:
https://youtu.be/auLS9RObIXY
Demo project: https://github.com/Aggror/SplineTools/tree/Spline-PR-1-demo
A spline entity exists out of SplineNodes (also entities) which are its children. These can be created entirely by code if so desired. To make them slightly more user friendly, these objects are utilised in components so that an editor user can view them inside the editor.
Some details
Spline traverser
An entity with a reference to the spline, can traverse the spline. A basic Spline traverser component has been added that support moving forward and backwards along the spline.
Types of changes
Checklist