Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: Update ServiceWire package to version 5.6.0 #2548

Merged

Conversation

VaclavElias
Copy link
Contributor

@VaclavElias VaclavElias commented Dec 7, 2024

  • Updated the ServiceWire package version in Directory.Packages.props from 5.5.4 to 5.6.0.

PR Details

The new package resolves System.Text.Json vulnerabilities, and some bug fixes, summary:

https://github.com/tylerjensen/ServiceWire#namedpipeserverstreamfactory-and-other-improvements-560

NamedPipeServerStreamFactory and Other Improvements 5.6.0

  1. Contributed fix where accepting TCP clients synchronously may block new clients from being accepted until the terminating request is received on the synchronous client.
  2. Contributed NamedPipeServerStreamFactory to allow greater level of permissions control in using named pipes.
  3. Introducted injectable ILog and IStats across channels and clients with default NullLogger and NullStats, making InjectLoggerStats obsolete.
  4. Code improvements for code consistency and eliminating outdated frameworks from tests and supporting projects.
  5. Updated several dependencies in supporting projects.
  6. Updated System.Text.Json to 9.0.0 to resolve known vulnerabilities in previous versions.

Related Issue

n/a

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

- Updated the ServiceWire package version in Directory.Packages.props from 5.5.4 to 5.6.0.
@Eideren Eideren merged commit d9df9dd into stride3d:master Dec 8, 2024
3 checks passed
@Eideren
Copy link
Collaborator

Eideren commented Dec 8, 2024

Thanks !

@VaclavElias
Copy link
Contributor Author

@Eideren, could you revert this PR? It would need some work from xen2 so we can leave it open or WIP till someone can look into #2566. Thanks.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants