Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: bepu, removal of collidables while running a contact event leaves contact tracking in an unexpected state #2603

Merged
merged 3 commits into from
Feb 1, 2025

Conversation

Eideren
Copy link
Collaborator

@Eideren Eideren commented Jan 25, 2025

PR Details

See title, doing this causes some issues in the tracking of contact events, refactoring the logic to avoid this.

Related Issue

None reported afaict

Types of changes

  • Docs change / refactoring / dependency upgrade
  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

Checklist

  • My change requires a change to the documentation.
  • I have added tests to cover my changes.
  • All new and existing tests passed.
  • I have built and run the editor to try this change out.

@Eideren Eideren marked this pull request as ready for review January 27, 2025 19:55
@Eideren Eideren changed the title fix: bepu, Re-entry/removal of collidables in contact events fix: bepu, removal of collidables while inside running a contact event leaves contact tracking in an unexpected state Jan 27, 2025
@Eideren Eideren changed the title fix: bepu, removal of collidables while inside running a contact event leaves contact tracking in an unexpected state fix: bepu, removal of collidables while running a contact event leaves contact tracking in an unexpected state Jan 27, 2025
@Eideren Eideren merged commit 6c9d6d1 into stride3d:master Feb 1, 2025
3 checks passed
@Eideren Eideren deleted the ctct_evts branch February 1, 2025 13:18
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant