Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Link Card Edit POC #10060

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from
Draft

Conversation

toluo-stripe
Copy link
Contributor

@toluo-stripe toluo-stripe commented Feb 1, 2025

Summary

Motivation

Testing

  • Added tests
  • Modified tests
  • Manually verified

Screenshots

Screen.Recording.2025-02-03.at.12.29.45.PM.mov

Changelog

Copy link
Contributor

github-actions bot commented Feb 1, 2025

Diffuse output:

OLD: paymentsheet-example-release-master.apk (signature: V1, V2)
NEW: paymentsheet-example-release-pr.apk (signature: V1, V2)

          │            compressed            │          uncompressed           
          ├───────────┬───────────┬──────────┼──────────┬──────────┬───────────
 APK      │ old       │ new       │ diff     │ old      │ new      │ diff      
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼───────────
      dex │     4 MiB │     4 MiB │   +5 KiB │  8.7 MiB │  8.7 MiB │ +13.9 KiB 
     arsc │   2.3 MiB │   2.3 MiB │      0 B │  2.3 MiB │  2.3 MiB │       0 B 
 manifest │   5.1 KiB │   5.1 KiB │      0 B │ 25.7 KiB │ 25.7 KiB │       0 B 
      res │ 910.3 KiB │ 910.3 KiB │      0 B │  1.4 MiB │  1.4 MiB │       0 B 
   native │   2.6 MiB │   2.6 MiB │      0 B │    6 MiB │    6 MiB │       0 B 
    asset │   1.6 MiB │   1.6 MiB │    +33 B │  1.6 MiB │  1.6 MiB │     +33 B 
    other │   1.4 MiB │   1.4 MiB │     -2 B │  1.6 MiB │  1.6 MiB │       0 B 
──────────┼───────────┼───────────┼──────────┼──────────┼──────────┼───────────
    total │  12.7 MiB │  12.7 MiB │ +5.1 KiB │ 21.7 MiB │ 21.7 MiB │   +14 KiB 

 DEX     │ old   │ new   │ diff              
─────────┼───────┼───────┼───────────────────
   files │     1 │     1 │   0               
 strings │ 41105 │ 41133 │ +28 (+73 -45)     
   types │ 14217 │ 14229 │ +12 (+49 -37)     
 classes │ 11873 │ 11885 │ +12 (+23 -11)     
 methods │ 60383 │ 60431 │ +48 (+3172 -3124) 
  fields │ 40539 │ 40577 │ +38 (+2572 -2534) 

 ARSC    │ old  │ new  │ diff 
─────────┼──────┼──────┼──────
 configs │  243 │  243 │  0   
 entries │ 6245 │ 6245 │  0
APK
     compressed      │     uncompressed      │                                           
──────────┬──────────┼───────────┬───────────┤                                           
 size     │ diff     │ size      │ diff      │ path                                      
──────────┼──────────┼───────────┼───────────┼───────────────────────────────────────────
    4 MiB │   +5 KiB │   8.7 MiB │ +13.9 KiB │ ∆ classes.dex                             
  7.8 KiB │    +26 B │   7.7 KiB │     +26 B │ ∆ assets/dexopt/baseline.prof             
  1,001 B │     +7 B │     869 B │      +7 B │ ∆ assets/dexopt/baseline.profm            
 53.6 KiB │     -3 B │ 118.8 KiB │       0 B │ ∆ META-INF/CERT.SF                        
    270 B │     -2 B │     120 B │       0 B │ ∆ META-INF/version-control-info.textproto 
  1.2 KiB │     +2 B │   1.2 KiB │       0 B │ ∆ META-INF/CERT.RSA                       
 50.3 KiB │     +1 B │ 118.8 KiB │       0 B │ ∆ META-INF/MANIFEST.MF                    
──────────┼──────────┼───────────┼───────────┼───────────────────────────────────────────
  4.1 MiB │ +5.1 KiB │     9 MiB │   +14 KiB │ (total)
DEX
STRINGS:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   41105 │ 41133 │ +28 (+73 -45) 
  
  + _this_CardDetailsUI2
  + , cardDefaultState=
  + , cardDetailsEntry=
  + , isUpdating=
  + CardDetailsEntry(date=
  + CardEditState(paymentDetail=
  + CardIsDefault
  + LB6/a;
  + LB6/b;
  + LB6/c;
  + LB6/d;
  + LB6/e;
  + LB6/f;
  + LB6/g;
  + LB6/h;
  + LB6/i;
  + LB6/j;
  + LB6/k;
  + LB6/l;
  + LB6/m;
  + LB6/n;
  + LB6/o;
  + LB6/p;
  + LB6/q;
  + LINK_LIST_PAYMENT_DETAILS_FAILURE
  + LINK_NATIVE_CARD_EDIT_PAYMENT_DETAILS_ID_NOT_FOUND
  + LK8/m;
  + LLLLLZLI
  + LN8/a;
  + LX7/H;
  + Landroidx/activity/J;
  + Lk9/s0;
  + Ly6/r;
  + Set As Default
  + VZLLZII
  + VZZLILI
  + Value(enabled=
  + [LC5/j;
  + [LZ8/H0;
  + [LZ8/I;
  + [LZ8/K0;
  + [LZ8/M;
  + [LZ8/b0;
  + [LZ8/i;
  + [LZ8/t0;
  + [Lb8/o;
  + [Lg6/F;
  + [Lk9/q0;
  + [Lm5/R0;
  + [Lu7/A0;
  + [Lu7/A;
  + [Lu7/O;
  + [Lu7/P0;
  + [Lu7/T;
  + [Lu7/W;
  + [Lu7/Y0;
  + [Lu7/Z;
  + [Lu7/k0;
  + [Lu7/m0;
  + [Lu7/o;
  + [Lu7/q0;
  + [Lu7/t0;
  + [Ly6/k;
  + cvc_expiry_row
  + date_exp
  + defaultValueChanged
  + defaultValueChanged(Z)V
  + link.list_payment_details.failure
  + link.native.card_edit.payment_details_id_not_found
  + updateCardClicked
  + updateCardClicked()V
  + updateExpirySize
  + ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"1875bd4","r8-mode":"full","version":"8.7.14"}
  
  - CardEditScreen
  - LC5/I;
  - LD7/G;
  - LD7/H;
  - LL0/E1;
  - LO5/s;
  - LZ8/w1;
  - LZ8/x1;
  - Lb8/D;
  - Lg6/L;
  - Ln7/n;
  - Lu7/B1;
  - VIILLZZ
  - VZLLLLIII
  - VZLLZLLI
  - VZLZII
  - VZLZLLI
  - VZLZLLLI
  - [LC5/k;
  - [LZ8/I0;
  - [LZ8/K;
  - [LZ8/N;
  - [LZ8/O0;
  - [LZ8/d0;
  - [LZ8/l;
  - [LZ8/u0;
  - [Lb8/p;
  - [Lg6/K;
  - [Lk9/p0;
  - [Lm5/U0;
  - [Lu7/E;
  - [Lu7/J0;
  - [Lu7/Q;
  - [Lu7/V0;
  - [Lu7/V;
  - [Lu7/Y;
  - [Lu7/Z0;
  - [Lu7/j0;
  - [Lu7/l0;
  - [Lu7/p0;
  - [Lu7/r0;
  - [Lu7/r;
  - [Lu7/z0;
  - [Ly6/j;
  - ~~R8{"backend":"dex","compilation-mode":"release","has-checksums":false,"min-api":21,"pg-map-id":"95a08ad","r8-mode":"full","version":"8.7.14"}
  

TYPES:

   old   │ new   │ diff          
  ───────┼───────┼───────────────
   14217 │ 14229 │ +12 (+49 -37) 
  
  + LB6/a;
  + LB6/b;
  + LB6/c;
  + LB6/d;
  + LB6/e;
  + LB6/f;
  + LB6/g;
  + LB6/h;
  + LB6/i;
  + LB6/j;
  + LB6/k;
  + LB6/l;
  + LB6/m;
  + LB6/n;
  + LB6/o;
  + LB6/p;
  + LB6/q;
  + LK8/m;
  + LN8/a;
  + LX7/H;
  + Landroidx/activity/J;
  + Lk9/s0;
  + Ly6/r;
  + [LC5/j;
  + [LZ8/H0;
  + [LZ8/I;
  + [LZ8/K0;
  + [LZ8/M;
  + [LZ8/b0;
  + [LZ8/i;
  + [LZ8/t0;
  + [Lb8/o;
  + [Lg6/F;
  + [Lk9/q0;
  + [Lm5/R0;
  + [Lu7/A0;
  + [Lu7/A;
  + [Lu7/O;
  + [Lu7/P0;
  + [Lu7/T;
  + [Lu7/W;
  + [Lu7/Y0;
  + [Lu7/Z;
  + [Lu7/k0;
  + [Lu7/m0;
  + [Lu7/o;
  + [Lu7/q0;
  + [Lu7/t0;
  + [Ly6/k;
  
  - LC5/I;
  - LD7/G;
  - LD7/H;
  - LL0/E1;
  - LO5/s;
  - LZ8/w1;
  - LZ8/x1;
  - Lb8/D;
  - Lg6/L;
  - Ln7/n;
  - Lu7/B1;
  - [LC5/k;
  - [LZ8/I0;
  - [LZ8/K;
  - [LZ8/N;
  - [LZ8/O0;
  - [LZ8/d0;
  - [LZ8/l;
  - [LZ8/u0;
  - [Lb8/p;
  - [Lg6/K;
  - [Lk9/p0;
  - [Lm5/U0;
  - [Lu7/E;
  - [Lu7/J0;
  - [Lu7/Q;
  - [Lu7/V0;
  - [Lu7/V;
  - [Lu7/Y;
  - [Lu7/Z0;
  - [Lu7/j0;
  - [Lu7/l0;
  - [Lu7/p0;
  - [Lu7/r0;
  - [Lu7/r;
  - [Lu7/z0;
  - [Ly6/j;
  

METHODS:

   old   │ new   │ diff              
  ───────┼───────┼───────────────────
   60383 │ 60431 │ +48 (+3172 -3124) 
  
  + A.b c() → E
  + A0.b <init>(w)
  + A5.c0 <init>(q, String, d)
  + A5.m0 <init>(E, d, int)
  + A5.y B(e, w) → f
  + A6.J <init>(l, c, c, a, a, a, a, c, int)
  + A6.T k(Object, Object, Object, Object) → Object
  + A6.U k(Object, Object, Object, Object) → Object
  + A6.V k(Object, Object, Object, Object) → Object
  + A6.W <init>(int, Object, Object)
  + A6.W k(Object, Object, Object, Object) → Object
  + A6.Z <init>(Integer, int, int)
  + A6.a0 <init>(p, String, d0, a, Integer, Integer, int, int)
  + A6.f k(Object, Object, Object, Object) → Object
  + A6.z j(Object, Object) → Object
  + A7.l k(Object, Object, Object, Object) → Object
  + B.a A(p, int, p) → u
  + B.a M(d0, p, float) → p
  + B.z m(Object, d) → Object
  + B6.a <clinit>()
  + B6.a equals(Object) → boolean
  + B6.a hashCode() → int
  + B6.a toString() → String
  + B6.b <init>(boolean)
  + B6.b equals(Object) → boolean
  + B6.b hashCode() → int
  + B6.b toString() → String
  + B6.d <clinit>()
  + B6.d <init>(i, i, i, i)
  + B6.d equals(Object) → boolean
  + B6.d hashCode() → int
  + B6.d toS
...✂

@toluo-stripe toluo-stripe changed the title VM tests Link Card Edit POC Feb 3, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant