Deprecate ServiceNested class #3051
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Compat issues are expected, since we're changing the base class of all of the Service classes. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
The ServiceNested used to contain methods that mirrored functionality from the Service base class but for nested services. These methods have been removed and ServiceNested is now effectively empty. This PR marks it for future deletion.
When working on this issue, I discovered Service is no longer needed as well, as all Service type parameters in use are defined at the method level.
What?
Changelog
ServiceNestedandService<T>classes. To implement custom services, use the request methods defined onStripeClient