Remove RawRequestOptions#ApiMode #3052
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
replaced ApiMode reference in LiveApiRequestor#RawRequestAsync with a call to GetApiMode updated tests to remove ApiMode option (to ensure GetApiMode works)
helenye-stripe
approved these changes
Feb 5, 2025
ramya-stripe
changed the title
ramya-stripe
reviewed
Feb 6, 2025
| @@ -1,12 +1,10 @@ | |||
| namespace Stripe | |||
| { | |||
| using System; | |||
There was a problem hiding this comment.
There is no net new code in this file... why this new import?
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Why?
When we shipped RawRequest functionality in the 9/30 release, most LiveApiRequestor calls were implemented to determine the API mode from the path. The exception to this was RawRequestAsync, which accepted ApiMode as an option. This is not a configurable option (it is either V1 or V2 depending on the API) and inspecting the path is a reliable way to determine ApiMode; specifying the wrong ApiMode means that responses may be interpreted incorrectly. Because of this, we are removing this option to avoid confusion and the potential for subtle errors.
What?
Changelog
ApiModefromRawRequestOptions. ApiMode is automatically determined from the path passed to RawRequest.