Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added fingerprint check validation for card and us bank #4207

Merged
merged 11 commits into from
Nov 1, 2024

Conversation

joyceqin-stripe
Copy link
Collaborator

@joyceqin-stripe joyceqin-stripe commented Oct 31, 2024

Summary

Added fingerprint checking logic in deferred validation for card and us_bank_account if PM ids don't match

Motivation

#4195
https://jira.corp.stripe.com/browse/RUN_MOBILESDK-3670

Testing

Changelog

Copy link
Collaborator

@yuki-stripe yuki-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice!

Copy link
Collaborator

@yuki-stripe yuki-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Let's add a CHANGELOG entry as well

CHANGELOG.md Outdated Show resolved Hide resolved
yuki-stripe
yuki-stripe previously approved these changes Oct 31, 2024
Copy link
Collaborator

@yuki-stripe yuki-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Oh I just realized this is untested right? Could we add a unit test for the new validatePaymentMethod behavior?

Copy link
Collaborator

@yuki-stripe yuki-stripe left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Excellent tests, thank you

@joyceqin-stripe joyceqin-stripe merged commit a1f5f95 into master Nov 1, 2024
6 checks passed
@joyceqin-stripe joyceqin-stripe deleted the joyceqin-issue-4195 branch November 1, 2024 18:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants