Hide default checkbox and auto-set if first #4643
Merged
+59
−42
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
porter-stripe
approved these changes
Mar 10, 2025
| @@ -2854,8 +2852,7 @@ class PaymentSheetDefaultSPMUITests: PaymentSheetUITestCase { | |||
| saveThisCardToggle.tap() | |||
| XCTAssertTrue(saveThisCardToggle.isSelected) | |||
| // do not set this card as default | |||
| setDefaultToggle = app.switches["Set as default payment method"] | |||
| XCTAssertFalse(setDefaultToggle.isSelected) | |||
| XCTAssertFalse(app.switches["Set as default payment method"].isSelected) | |||
There was a problem hiding this comment.
Do we need this? Is the "Set as default payment method" even visible?
There was a problem hiding this comment.
We previously saved a card, so the "Set as default payment method" checkbox is shown when we try adding another card. Since the new card wouldn't be the only saved payment method, it wouldn't automatically be set as the default.
wooj-stripe
approved these changes
Mar 10, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
If a customer has no saved payment methods and the default feature is enabled, hide the default checkbox and automatically set new card or US bank account as the default.
Motivation
Bug bash suggestion
Testing
Updated UI test
Changelog