Make httpClient() a public, static method

[dejagersh]

Why?

I want to do something like this with ApiRequestor::setHttpClient():

in tests:

ApiRequestor::setHttpClient($this->createMock(...));

in application code:

ApiRequestor::setHttpClient(new LoggingHttpClient($this->logger))

If you first execute the ApiRequestor::setHttpClient in test, and then afterwards the ApiRequestor::setHttpClient() in application code, then the mocked http client is gone and this goes wrong. What I think would be a nice solution: allow me to decorate the configured http client:

class LoggingHttpClient implements ClientInterface
{
    public function __construct(
        private LoggerInterface $logger,
        private ClientInterface $decorated,
    ) {
    }

    /**
     * @see ClientInterface::request()
     */
    public function request($method, $absUrl, $headers, $params, $hasFile): array
    {
        [$rawResponseBody, $statusCode, $responseHeaders] = $this->decorated->request(
            $method,
            $absUrl,
            $headers,
            $params,
            $hasFile,
        );

        // $this->logger->...

        return [$rawResponseBody, $statusCode, $responseHeaders];
    }
}

And then wherever I configure the logging http client I can instantiate this class decorating the previously configured http client:

ApiRequestor::setHttpClient(new LoggingHttpClient($this->logger, ApiRequestor::httpClient());

Now LoggingHttpClient decorates the mock client and things work as intended. It kinda becomes a middleware pattern, and opens the door for other middleware, e.g.:

ApiRequestor::setHttpClient(
    new MetricsHttpClient(
        new RetryingHttpClient(
            new CachingHttpClient(
                new LoggingHttpClient(
                    $this->logger,
                    ApiRequestor::httpClient()
                ),
                $this->cache
            )
        ),
        $this->metrics
    )
);

What?

• Make httpClient() public and static

See Also

NA

[cla-assistant]

All committers have signed the CLA.

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you sign our Contributor License Agreement before we can accept your contribution.
_{You have signed the CLA already but the status is still pending? Let us recheck it.}