Add a warning regarding opting out of the new architecture. #1816
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
seanzhang-stripe
requested review from
charliecruzan-stripe and
a team
as code owners
charliecruzan-stripe
previously approved these changes
Jan 24, 2025
amk-stripe
reviewed
Jan 27, 2025
README.md
Outdated
| @@ -5,6 +5,9 @@ | |||
|
|
|||
| The Stripe React Native SDK allows you to build delightful payment experiences in your native Android and iOS apps using React Native. We provide powerful and customizable UI screens and elements that can be used out-of-the-box to collect your users' payment details. | |||
|
|
|||
| > [!WARNING] | |||
| > This SDK is not fully compatible with React Native's [New Architecture](https://reactnative.dev/blog/2024/10/23/the-new-architecture-is-here). If you are using React Native 0.76 or above, please [opt-out](https://reactnative.dev/blog/2024/10/23/the-new-architecture-is-here#opt-out) from it. | |||
There was a problem hiding this comment.
should we indicate that we intend to upgrade to the new architecture at some point? I worry people will see this and think that we have no intention to upgrade
amk-stripe
approved these changes
Jan 28, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary
Add a warning regarding opting out of the new architecture.
Motivation
Testing
Documentation
Select one: