Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

docs: add OS 101 to readme #64

Merged
merged 2 commits into from
Jan 26, 2023
Merged

docs: add OS 101 to readme #64

merged 2 commits into from
Jan 26, 2023

Conversation

niek-mereu
Copy link
Collaborator

docs: add OS 101 to readme

docs: add OS 101 to readme

📝 Changelog

  • added OS documentation to the Readme.

🔗 Links

@niek-mereu niek-mereu self-assigned this Jan 16, 2023
@niek-mereu niek-mereu marked this pull request as draft January 16, 2023 17:13
@niek-mereu niek-mereu marked this pull request as ready for review January 17, 2023 08:29
joeythedataguy
joeythedataguy reviewed Jan 17, 2023
View reviewed changes
README.md Outdated Show resolved Hide resolved
joeythedataguy
joeythedataguy requested changes Jan 17, 2023
View reviewed changes
Copy link
Collaborator

@joeythedataguy joeythedataguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It’s good but I would welcome more examples and to have them first. E.g. have one sample text break by all analyzers. Maybe even a table where each row is different text (sentence, email, username) and then columns are each analyzer.
What do you think?

joeythedataguy
joeythedataguy approved these changes Jan 26, 2023
View reviewed changes
Copy link
Collaborator

@joeythedataguy joeythedataguy left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice, thank you for the update!

@niek-mereu niek-mereu merged commit 2ee6259 into master Jan 26, 2023
@niek-mereu niek-mereu deleted the docs/OS-docs branch January 26, 2023 09:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@joeythedataguy joeythedataguy joeythedataguy approved these changes

Assignees

@niek-mereu niek-mereu

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@niek-mereu @joeythedataguy