Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: support different configs (TEST - needs review) #32

Closed
wants to merge 1 commit into from
Closed

feat: support different configs (TEST - needs review) #32

wants to merge 1 commit into from

Conversation

bartekleon
Copy link
Member

@bartekleon bartekleon commented Sep 14, 2018

It is just a test if you like it or not. I could continue work on this and support all configurations available right now (at least most of them) [from experience i know that this is pain to download each package, run npm install, check if it works, and again {infinite loop}. Using this method user would only click which template wants, and then only make up configs]
TODO:
Optimisations (text optimisation)
Tests (which are not up to date right now)
Support more templates

Features:
Send user to some site with sample config (github, docs, whatever).

@bartekleon bartekleon changed the title feat: support different configs feat: support different configs (TEST) Sep 14, 2018
@bartekleon bartekleon changed the title feat: support different configs (TEST) feat: support different configs (TEST - needs review) Sep 14, 2018
@nicojs
Copy link
Member

nicojs commented Sep 16, 2018

I'm a bit confused. Is the idea here to support demo configurations as suggested in stryker-mutator/stryker-js#1124? Or presets as specified here: stryker-mutator/stryker-js#1049

In either case, shouldn't it be implemented in stryker itself and not the stryker-cli? The stryker-cli's job is is to forward commands to the local Stryker instance (so installed in your node_modules). If it isn't yet installed it prompts for install.

I have plans to remove the stryker-cli in favor of suggesting to use npx stryker init, but should be investigated. See #33

@bartekleon
Copy link
Member Author

bartekleon commented Sep 16, 2018

This is a mid solution - just to install all required packages at once, not forcing user to run it 10 times coz he misses 1 package.
I understood that you don't want templates at all (so fully configured projects) as i was introducing in stryker-mutator/stryker-js#1124
Well, still it's up to you which one you do prefer. I can make either or them, and try to maintain them.

@nicojs
Copy link
Member

nicojs commented Sep 17, 2018

just to install all required packages at once, not forcing user to run it 10 times coz he misses 1 package.

I'm curious about what the usecase exactly is. If stryker init results in the wrong packages being installed time and time again, I would suggest improving the way stryker init works. I think the presets from stryker-mutator/stryker-js#1049 would help a lot with this.

Closing this for now. As we're thinking of deprecating this project in favor of npx stryker init (#33)

@nicojs nicojs closed this Sep 17, 2018
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants