[DRAFT] Mutation server #4877
Closed
[DRAFT] Mutation server #4877
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Mutation Server
Mutate method
Real-time updates
Unit tests for mutation server code
nicojs
requested changes
Jun 21, 2024
| } | ||
|
|
||
| private async requestCancellationMiddleware(next: JSONRPCServerMiddlewareNext<void>, request: JSONRPCRequest, serverParams: void) { | ||
| if (request.id) { |
There was a problem hiding this comment.
id can be a number or a string, both of which have falsy values. You probably want an undefined check here.
| const abortController = this.cancellableRequests.get(jsonRPCRequest.id); | ||
|
|
||
| if (!abortController) { | ||
| throw new Error('No cancellation token found for request'); |
There was a problem hiding this comment.
This shouldn't happen, but because of the way you've implemented the middlewares it is actually a requirement you have to deal with it here. I think there must be a better way, let's talk about this.
| import { ConfigError, retrieveCause } from '../../errors.js'; | ||
| import { LogConfigurator } from '../../logging/log-configurator.js'; | ||
|
|
||
| export class MutationTestMethod { |
There was a problem hiding this comment.
This is a copy of the Stryker class. Why have 2 separate processes for the same thing? I think we should reuse the Stryker class.
| import { MutantInstrumenterContext } from '../../../process/2-mutant-instrumenter-executor.js'; | ||
|
|
||
| export class MutantInstrumenterExecutor { | ||
| public static readonly inject = tokens(commonTokens.injector, coreTokens.project, commonTokens.options, coreTokens.pluginCreator); |
There was a problem hiding this comment.
Same as my previous remark. We should try to reuse as much as we can.
| @@ -0,0 +1,3 @@ | |||
| // Stryker disable file | |||
| export const port = 'port'; | |||
There was a problem hiding this comment.
We can simply add these to the 'core tokens'
* feat(server): Add versioning and capabilities handshake * fix: Close websocket transporter after test * refactor: Rename 'mutate' request to 'mutationTest' * fix: Tests failing due to rename * chore: Upgrade ws package to fix vulnerability * Revert "chore: Upgrade ws package to fix vulnerability" This reverts commit 428e2d4.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This pull request introduces a mutation server within the core module of StrykerJS, implementing the Mutation Server Protocol. This server facilitates communication between StrykerJS and external clients, specifically the (unpublished) vscode-stryker IDE extension.
The Mutation Server Protocol is designed to enhance the integration and interaction between Stryker mutation testing frameworks and development tools, offering a standardized method for communication. The protocol leverages JSON-RPC messages for its operations, ensuring a consistent and efficient communication pattern. The detailed reasoning and decision-making process for the Mutation Server Protocol can be found in the corresponding ADR (Architectural Decision Record). As of now, messages are transported using a web socket, the corresponding ADR for this decision can be found here.
To further enhance modularity and reusability, there are plans to extract the Mutation Server Protocol into a separate npm package. This will allow other projects to easily adopt and implement the protocol.
The VS Code extension, the Mutation Server Protocol and its implementation in StrykerJS were developed as part of my internship. I am eager to hear your thoughts and feedback on this implementation.