Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(ui): make console output more readable #3047

Closed
wants to merge 2 commits into from

Conversation

draptik
Copy link
Contributor

@draptik draptik commented Sep 26, 2024

Using Serilog's AniConsoleTheme.Sixteen improves readability of the console log output on dark and light background consoles. See #3046 for details.

draptik and others added 2 commits September 26, 2024 15:50
Using Serilog's AniConsoleTheme.Sixteen improves readability of the console log output on dark and light background consoles.
See stryker-mutator#3046 for details.
@rouke-broersma
Copy link
Member

rouke-broersma commented Sep 27, 2024

@draptik I'm testing out the change on my own system and the default theme already seems to be working fine for me on light themes. Coupled with the note by the serilog team that ansi themes don't work well on cmd that makes me hesitant to approve the change.

Could there by anything in your specific environment configuration that's affecting this? If I run the latest released version of stryker in the VS console with light theme the console output colour is black, not white as in yours:

image

In fact if you look at your own example you can see that the default text colour for the terminal seems to actually be white, because all other printed text is also white:

image

So it seems to me like serilog is actually following the configured terminal colors.

@draptik
Copy link
Contributor Author

draptik commented Sep 30, 2024

OK, understood. Thanks for the update!
Since this issue seems to be more involved than I initially thought, feel free to discard this PR.

@rouke-broersma
Copy link
Member

OK, understood. Thanks for the update!
Since this issue seems to be more involved than I initially thought, feel free to discard this PR.

Could you give some more information on your terminal theme/configuration so we could determine whether the results you're seeing are intentional or not?

@draptik
Copy link
Contributor Author

draptik commented Sep 30, 2024

Sure.

  • linux: kitty terminal "Tango Light" / "Tango Dark"
  • windows: Windows Terminal "Tango Light" / Tango Dark"
  • Rider (linux/windows): built-in terminal with "Rider Dark" / "Rider Day" themes.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants