Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Clearfix tabs #138

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Clearfix tabs #138

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
086b930
.pop module doesn't look right, fix it
seanjsong Nov 10, 2012
2cfe84e
tabs plugin needs a clearfix
seanjsong Nov 11, 2012
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 5 additions & 4 deletions core/module/mod.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -26,8 +26,9 @@ b.top, b.top b, b.bottom, b.bottom b{display:block;background-repeat:no-repeat;f
.complex .top{height:5px;}
.complex .bottom{height:5px;/*margin-top:-10px;*/}
/* pop */
.pop{overflow:visible;margin: 10px 20px 20px 10px; background-position:left top;}
.pop .inner{right:-10px; bottom:-10px; background-position:right bottom;padding:0 10px 10px 0;}
.pop{overflow:visible;margin: 10px 20px 20px 10px; background-position:left top; padding-top:1px;/*padding to avoid margin collapsing*/}
.pop .inner{right:-10px; bottom:-10px; margin:9px -10px -10px 10px; background-position:right bottom;padding:0 10px 10px 0;}
.pop .tl, .pop .br{display:none;}
.pop .bl{bottom:-10px;}
.pop .tr{float:right;margin-right:-10px;_display:inline; /*fix double margin bug*/ }
.pop .bottom{height:0;}
.pop .bl{float:none;}
.pop .tr{float:right;margin-right:-10px;margin-top:-1px;/*corresponding to padding*/_display:inline;/*fix double margin bug*/ }
28 changes: 27 additions & 1 deletion plugins/tabs/tabs.css
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -30,6 +30,32 @@ TODO: clean up selector structure - too much variation in rule strength
.controls{position:absolute; top:0; right: 0; display: none !important; /* this should move to its' own plugin */}
.controls a{padding: 10px;}

/**
* For modern browsers
* 1. The space content is one way to avoid an Opera bug when the
* contenteditable attribute is included anywhere else in the document.
* Otherwise it causes space to appear at the top and bottom of elements
* that are clearfixed.
* 2. The use of `table` rather than `block` is only necessary if using
* `:before` to contain the top-margins of child elements.
*/
.cf:before,
.cf:after {
content: " "; /* 1 */
display: table; /* 2 */
}

.cf:after {
clear: both;
}

/**
* For IE 6/7 only
* Include this rule to trigger hasLayout and contain floats.
*/
.cf {
*zoom: 1;
}

.tabPosLeft .hd .tabControl .current {background-image:none; border-bottom:solid 1px #e2e2e2;border-right:none; margin-right:-1px;}
.tabPosLeft .tabControl li{border-right:none;}
Expand Down Expand Up @@ -65,4 +91,4 @@ TODO: clean up selector structure - too much variation in rule strength
.tabs .hd ul{background-color: blue;}
.tabs .hd ul li{background-color: yellow;}
.tabs .hd ul li a{background-color: orange;}
*/
*/
4 changes: 2 additions & 2 deletions plugins/tabs/tabs_doc.html
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -53,7 +53,7 @@ <h2>Bottom Tabs</h2>
<h2>Left-side tabs</h2>
<div class="mod simple tabs tabPosLeft">
<b class="top"><b class="tl"></b><b class="tr"></b></b>
<div class="inner">
<div class="inner cf">
<div class="hd topper">
<ul class="tabControl"><li><a href="#"><span>Tab 1</span></a></li><li><a href="#"><span>Tab 2</span></a></li><li class="current"><a href="#"><span>Tab 3 <br /> boo foo foo</span></a></li><li><a href="#"><span>Tab 4</span></a></li><li><a href="#"><span>Tab 5</span></a></li><li><a href="#"><span>Tab 6 has lots and lots of text on one line</span></a></li></ul>
<ul class="controls"><li><a href="#"><span>x</span></a></li><li><a href="#"><span>-</span></a></li><li><a href="#"><span>+</span></a></li></ul>
Expand All @@ -76,7 +76,7 @@ <h2>Left-side tabs</h2>
<h2>Right-side tabs</h2>
<div class="mod simple tabs tabPosRight">
<b class="top"><b class="tl"></b><b class="tr"></b></b>
<div class="inner">
<div class="inner cf">
<div class="hd topper">
<ul class="tabControl"><li><a href="#"><span>Tab 1</span></a></li><li><a href="#"><span>Tab 2</span></a></li><li class="current"><a href="#"><span>Tab 3 <br /> boo foo foo</span></a></li><li><a href="#"><span>Tab 4</span></a></li><li><a href="#"><span>Tab 5</span></a></li><li><a href="#"><span>Tab 6 has lots and lots of text on one line</span></a></li></ul>
<ul class="controls"><li><a href="#"><span>x</span></a></li><li><a href="#"><span>-</span></a></li><li><a href="#"><span>+</span></a></li></ul>
Expand Down