Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove parse error hack for CHANGELOG.md #358

Closed
wants to merge 1 commit into from
Closed

Remove parse error hack for CHANGELOG.md #358

wants to merge 1 commit into from

Conversation

ybiquitous
Copy link
Member

Which issue, if any, is this issue related to?

Follow-up to #357

Is there anything in the PR that needs further explanation?

This PR removes the no longer needed hack for a parse error in CHANGELOG.md. The error cause has been already removed in the stylelint/stylelint repository.

Note: We need to merge this PR when releasing the next Stylelint version.

See also:

@ybiquitous ybiquitous added the pr: blocked is blocked by another issue or pr label Nov 5, 2023
jeddy3
jeddy3 approved these changes Nov 5, 2023
View reviewed changes
Copy link
Member

@jeddy3 jeddy3 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM.

@ybiquitous
Copy link
Member Author

ybiquitous commented Nov 10, 2023 •
edited
Loading

I've cherry-picked the commit (8a6c4d8) in this PR into #359. So, this PR is no longer needed. We can publish the change along with #359.

@ybiquitous ybiquitous closed this Nov 10, 2023
@ybiquitous ybiquitous deleted the remove-hack-for-changelog branch November 10, 2023 16:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jeddy3 jeddy3 jeddy3 approved these changes

Assignees
No one assigned
Labels
pr: blocked is blocked by another issue or pr
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@ybiquitous @jeddy3