Fix build warning for require.resolve()
#506
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
rchl
reviewed
Feb 14, 2024
ota-meshi
approved these changes
Mar 22, 2024
This change doesn't use `require.resolve()` to prevent the build warning below: ```sh-session $ npm run bundle > [email protected] bundle > npm run bundle-base -- --sourcemap > [email protected] bundle-base > ts-node --transpile-only -P tsconfig.scripts.json scripts/bundle.ts --sourcemap ▲ [WARNING] "./start-server" should be marked as external for use with "require.resolve" build/extension/extension.js:13:39: 13 │ const serverPath = require.resolve('./start-server'); ╵ ~~~~~~~~~~~~~~~~ 1 warning ```
ybiquitous
force-pushed
the
fix-build-warning
branch
from
45f82f3 to
b2ae72d
Compare
|
Thanks for the review. I just resolved conflicts, so I'll merge this. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This change doesn't use
require.resolve()to prevent the build warning below:None.
No, it's self-explanatory.