Add DFP endpoints #68
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
logan-stytch
approved these changes
Jan 3, 2025
| @@ -42,7 +44,7 @@ import kotlinx.coroutines.CoroutineScope | |||
| import kotlinx.coroutines.SupervisorJob | |||
| import org.jose4j.jwk.HttpsJwks | |||
|
|
|||
| public class StytchB2BClient(projectId: String, secret: String) { | |||
| public class StytchB2BClient(projectId: String, secret: String, fraudBaseUrl: String = "https://telemetry.stytch.com") { | |||
There was a problem hiding this comment.
In order to allow default parameters in Java (ie: not have to specify the URL), you need to annotate the constructor with @JvmOverloads. This tells the compiler to create every possible permutation with and without default parameters.
So this should be:
public class StytchClient @JvmOverloads constructor (projectId: String, secret: String, fraudBaseUrl: String = "https://telemetry.stytch.com") {
jhaven-stytch
approved these changes
Jan 6, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the two backend DFP endpoints:
/v1/fingerprint/lookupand /v1/rules/set.Base URLs for both the API and DFP endpoints are now configurable via the
OptionalClientConfigparameter on theStytchClientandStytchB2BClient.Marking as MAJOR because of the
metric_typefix from optional to required.