-
Notifications
You must be signed in to change notification settings - Fork 13
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore: adjust syntax to python type hints #246
chore: adjust syntax to python type hints #246
Conversation
sublimehq/Packages#3736 has been merged and might be released with one of then next ST dev builds. |
What will happen for current stable build users if we merge and release this? |
This being merged requires another I haven't investigated impact of implementing sublimehq/Packages#3793 so far. |
In that case, I would choose to vendor (like https://github.com/sublimelsp/LSP-pyright/blob/st3/syntaxes/Python.sublime-syntax) Python syntax file with PR #3736 until there is a new stable release. Because LSP-pyright already branches ST 3 release and ST 4 release, I wouldn't like to create yet another one. And if we vendor it, this can be kind of being merged right now. |
Sounds like a plan to make transition smoother. |
For smoother transition, see #246 Signed-off-by: Jun-Fei Cherng <[email protected]>
Let's change extends: Packages/Python/Python.sublime-syntax to extends: Packages/LSP-pyright/syntaxes/Python.sublime-syntax |
This PR provides required adjustments for pyright's syntax to work with sublimehq/Packages#3736.
Unfortunately some of mensioned PRs changes break current syntax and I found no sane way around it.