Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use <kdb> syntax to fix render. #19

Closed
wants to merge 1 commit into from
Closed

Use <kdb> syntax to fix render. #19

wants to merge 1 commit into from

Conversation

ryanpcmcquen
Copy link

Is there a reason <Key k= is used instead of <kbd>. The latter would also render correctly in the source file in GitHub. The former does not render correctly for me in the site (Firefox on Mac OS), it appears as below:

Screen Shot 2020-06-12 at 12 23 05 PM

@TerminalFi
Copy link
Contributor

is a Vuejs component that we are using in our templates. It handles properly splitting Ctrl+shift+v to the proper KBD html components.

@ryanpcmcquen
Copy link
Author

Ah, that's nice. Any idea why the Tab key isn't rendering properly for me?

@TerminalFi
Copy link
Contributor

Can you share the page and how it shows for you?

@ryanpcmcquen
Copy link
Author

There's a screenshot above, but here's a full one:
Screenshot_2020-06-12 Completions Sublime Text Community Documentation

And it's the same as the file edited in this PR:
https://docs.sublimetext.io/guide/extensibility/completions.html

@TerminalFi
Copy link
Contributor

Gotcha, seems to be an issue with unicode in Firefox. I am going to close this PR, but can you open an issue?

@FichteFoll
Copy link
Member

FichteFoll commented Jun 12, 2020

It seems that you don't have a font with the sigil. We should probably consider prodiding a font with these "exotic" glyphs since they are most likely not guaranteed to be present on every system.

The PR will need to be rejected, because this is not the proper fix to the problem.

@FichteFoll
Copy link
Member

Opened #20 as a result of this.

@FichteFoll FichteFoll closed this Jun 13, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants