Ensure event ordering in the resource syncer #953
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
Oats87,
skitt,
sridhargaddam and
vthapar
as code owners
|
🤖 Created branch: z_pr953/tpantelis/syncer_event_ordering |
aswinsuryan
approved these changes
Jul 17, 2024
If a resource is deleted and then quickly re-created, depending on timing, the delete event might not get processed so consumers only observe the re-creation event which is not desirable in some cases. To ensure events are not missed and are processed in order, a per-resource queue was added to mantain create and delete operations in place of the separate created and deleted maps. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
syncer_event_ordering
branch
from
70864b6 to
b2596af
Compare
yboaron
approved these changes
Jul 18, 2024
|
🤖 Closed branches: [z_pr953/tpantelis/syncer_event_ordering] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
If a resource is deleted and then quickly re-created, depending on timing, the delete event might not get processed so consumers only observe the re-creation event which is not desirable in some cases. To ensure events are not missed and are processed in order, a per-resource queue was added to mantain create and delete operations in place of the separate created and deleted maps.