Retry ipset DestroySet/DestroyAllSets if error indicates in use #2978
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
tpantelis
requested review from
aswinsuryan,
dfarrell07,
maayanf24,
Oats87,
skitt,
sridhargaddam,
vthapar and
yboaron
as code owners
|
🤖 Created branch: z_pr2978/tpantelis/ipset_destroy |
aswinsuryan
approved these changes
Apr 15, 2024
dfarrell07
approved these changes
Apr 16, 2024
|
This PR/issue depends on:
|
|
The unit test failure is unrelated to the changes in this PR. It was orthogonally introduced by the admiral bump and is addressed by submariner-io/admiral#891. |
tpantelis
force-pushed
the
ipset_destroy
branch
from
66f311c to
87e0072
Compare
...instead of the K8s exec wrapper as the former provides a fake implementation that is simpler and easer to use. Signed-off-by: Tom Pantelis <[email protected]>
This handles the case where a set is destroyed right after associated IP table rule(s) are deleted where the latter may not be complete yet. Retry up to 2 seconds. Fixes submariner-io#1746 Signed-off-by: Tom Pantelis <[email protected]>
Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
force-pushed
the
ipset_destroy
branch
from
87e0072 to
d170b91
Compare
yboaron
approved these changes
Apr 18, 2024
|
🤖 Closed branches: [z_pr2978/tpantelis/ipset_destroy] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This handles the case where a set is destroyed right after associated IP table rule(s) are deleted where the latter may not be complete yet. Retry up to 2 seconds.
Fixes #1746
Depends on submariner-io/admiral#886