Update nat discovery to support IP family #3311
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yboaron
requested review from
Oats87,
skitt,
sridhargaddam,
tpantelis and
vthapar
as code owners
|
🤖 Created branch: z_pr3311/yboaron/natd_v6 |
yboaron
force-pushed
the
natd_v6
branch
2 times, most recently
from
2037527 to
ed5f380
Compare
tpantelis
requested changes
Feb 24, 2025
tpantelis
force-pushed
the
natd_v6
branch
3 times, most recently
from
073b667 to
4bd5fac
Compare
tpantelis
requested changes
Feb 25, 2025
| delete(i.natDiscoveryPending, rnat.Endpoint.Spec.CableName) | ||
| i.natDiscoveryPending[familyCableName]-- | ||
| if i.natDiscoveryPending[familyCableName] == 0 { | ||
| delete(i.natDiscoveryPending, familyCableName) |
There was a problem hiding this comment.
I think installedCables below will have to index by familyCableName as well but we can address that when cable drivers handle the family.
Current code assumes 1:1 mapping between endpoint to nat-discovery and endpoint to submariner inter-cluster tunnel. Since we decided that we continue using a single endpoint for each cluster also for dual-stack, it is necessary to support mapping endpoint up to 2 nat-discovery and inter-cluster tunnels. Additionally, nat-discovery and submariner-tunnel also need to support IP family parameter, as both IPv4 and IPv6 should be supported. This change update nat-discovery to support IP family,to make it clear, only IPV4 nat-discovery is supported even after this change. Signed-off-by: Yossi Boaron <[email protected]>
Also modified signature to return a slice instead of a fixes-sized array. Signed-off-by: Tom Pantelis <[email protected]>
tpantelis
approved these changes
Feb 25, 2025
vthapar
approved these changes
Feb 26, 2025
|
@yboaron Does this need backport to 0.20? |
I don't think so, only refactoring the code to support IP family which is relevant for IPV6,dual-stack use case (planned for 0.21) |
|
🤖 Closed branches: [z_pr3311/yboaron/natd_v6] |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Current code assumes 1:1 mapping between endpoint to nat-discovery and
endpoint to submariner inter-cluster tunnel.
Since we decided that we continue using a single endpoint for each cluster
also for dual-stack, it is necessary to support mapping endpoint up to 2
nat-discovery and inter-cluster tunnels.
Additionally, nat-discovery and submariner-tunnel also need
to support IP family parameter, as both IPv4 and IPv6 should be supported.
This change update nat-discovery to support IP family, to make it clear,
only IPV4 nat-discovery is supported even after this change.