Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Fix algorand using wrong value for block hash #120

Merged
merged 2 commits into from
May 13, 2024
Merged

Conversation

stwiname
Copy link
Contributor

Description

For some reason round as a string was used for the block hash, this now corrects this which in turn fixes POI because it was unable to work correctly with a number

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

Copy link

github-actions bot commented May 13, 2024

Coverage report

Caution

Test run failed

St.
Category Percentage Covered / Total
🔴 Statements 32.61% 1062/3257
🔴 Branches 54.72% 58/106
🔴 Functions 22.05% 28/127
🔴 Lines 32.61% 1062/3257

Test suite run failed

Failed tests: 1/16. Failed suites: 1/4.
  ● ApiService › waits on pending block to fetch hash

    expect(received).toBeDefined()

    Received: undefined

      86 |
      87 |     const block = await fetchLatestBlock();
    > 88 |     expect(block.block.hash).toBeDefined();
         |                              ^
      89 |   });
      90 | });
      91 |

      at Object.<anonymous> (packages/node/src/indexer/api.service.spec.ts:88:30)

Report generated by 🧪jest coverage report action from 725669d

@stwiname stwiname merged commit 17ca3d2 into main May 13, 2024
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants