Sync with main SDK for project upgrades feature #60
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Coverage report❌ An unexpected error occurred. For more details, check console
Test suite run failedFailed tests: 1/11. Failed suites: 1/3.Report generated by 🧪jest coverage report action from 2f250bd |
jiqiang90
suggested changes
Oct 3, 2023
| @ValidateNested() | ||
| @Type(() => FileType) | ||
| @IsOptional() | ||
| chaintypes?: FileType; | ||
| @IsOptional() | ||
| @IsArray() | ||
| bypassBlocks?: (number | string)[]; |
There was a problem hiding this comment.
bypassBlocks?: (number | ${number}-${number})[];
| argv._[0] === 'force-clean' | ||
| ) | ||
| ) { | ||
| // Check for no subcommand |
There was a problem hiding this comment.
do we need this too
(BigInt.prototype as any).toJSON = function () {
return this.toString();
};
There was a problem hiding this comment.
I don't think so. Near doesn't seem to use much BigInt
| extends CoreDictionaryService | ||
| implements OnApplicationShutdown | ||
| { | ||
| export class DictionaryService extends CoreDictionaryService { |
There was a problem hiding this comment.
I suppose line 13-19, specVersions is not used in Near?
| dataSources: SubqlProjectDs[], | ||
| getVM: (d: SubqlProjectDs) => Promise<IndexerSandbox>, | ||
| dataSources: NearProjectDs[], | ||
| getVM: (d: NearProjectDs) => Promise<IndexerSandbox>, |
There was a problem hiding this comment.
line 184 baseCustomHandlerFilter not used?
There was a problem hiding this comment.
Its used by BaseIndexerManager
jiqiang90
approved these changes
Oct 4, 2023
jiqiang90
suggested changes
Oct 4, 2023
packages/types/package.json
Outdated
| @@ -16,6 +16,7 @@ | |||
| "/dist" | |||
| ], | |||
| "dependencies": { | |||
| "@subql/types-core": "^0.1.0", | |||
jiqiang90
approved these changes
Oct 4, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Sync with main SDK to get new project upgrades feature and POI rework
Type of change
Please delete options that are not relevant.
Checklist