Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix for block skipping on workers #82

Merged
merged 2 commits into from
Nov 13, 2023
Merged

Conversation

bz888
Copy link
Contributor

@bz888 bz888 commented Nov 9, 2023

Description

Please include a summary of the change and which issue is fixed. Please also include relevant motivation and context. List any dependencies that are required for this change.

Fixes #81

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

Copy link

github-actions bot commented Nov 9, 2023

Coverage report

❌ An unexpected error occurred. For more details, check console

Error: The process '/usr/local/bin/yarn' failed with exit code 1
St.
Category Percentage Covered / Total
🔴 Statements 34.48% 1292/3747
🔴 Branches 54.7% 64/117
🔴 Functions 13.85% 18/130
🔴 Lines 34.48% 1292/3747

Test suite run failed

Failed tests: 1/11. Failed suites: 1/3.
  ● dictionary service › successfully validates metatada

    expect(received).resolves.toBeTruthy()

    Received: false

      27 |     await expect(
      28 |       dictionaryService.initValidation('mainnet'),
    > 29 |     ).resolves.toBeTruthy();
         |                ^
      30 |   });
      31 | });
      32 |

      at Object.toBeTruthy (node_modules/expect/build/index.js:174:22)
      at Object.<anonymous> (packages/node/src/indexer/dictionary.service.spec.ts:29:16)

Report generated by 🧪jest coverage report action from 6717188

@bz888 bz888 force-pushed the fix/workers-unavailable-blocks branch from 65f9bef to 6717188 Compare November 13, 2023 10:19
@jiqiang90 jiqiang90 merged commit fdc2741 into main Nov 13, 2023
2 of 3 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Unable to skip unavailable blocks when running workers
2 participants