Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Always flush cache on every block when near target height #2707

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

stwiname
Copy link
Collaborator

@stwiname stwiname commented Mar 4, 2025

Description

The purpose of the cache is to group together a large number of blocks data into fewer larger DB operations. This makes sense when indexing historical data but when indexing new data this doesn't matter as much and there is a preference to make data accessible for querying ASAP. This change makes it so that every block flushes the cache to the DB when within 10 (default value, is configurable) blocks of the target height.

Fixes # (issue)

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist

  • I have tested locally
  • I have performed a self review of my changes
  • Updated any relevant documentation
  • Linked to any relevant issues
  • I have added tests relevant to my changes
  • Any dependent changes have been merged and published in downstream modules
  • My code is up to date with the base branch
  • I have updated relevant changelogs. We suggest using chan

Copy link

github-actions bot commented Mar 4, 2025

Coverage report for .

St.
Category Percentage Covered / Total
🟡 Statements
67.48% (-2.63% 🔻)
20562/30473
🟡 Branches
79.04% (+0.75% 🔼)
2798/3540
🟡 Functions
70.09% (+7.59% 🔼)
1125/1605
🟡 Lines
67.48% (-2.63% 🔻)
20562/30473
Show new covered files 🐣
St.
File Statements Branches Functions Lines
🟢
... / migrate.ts
85.34% 9.09% 100% 85.34%
🟢
... / migrate-abis.controller.ts
95% 87.5% 100% 95%
🟢
... / constants.ts
100% 100% 100% 100%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / ethereum.ts
82.28% 83.33% 100% 82.28%
🟢
... / migrate-manifest.controller.ts
88% 72.41% 88.89% 88%
🟢
... / migrate-mapping.controller.ts
100% 100% 100% 100%
🟢
... / migrate-controller.ts
92.41% 84.62% 100% 92.41%
🟢
... / migrate.fixtures.ts
100% 100% 100% 100%
🟢
... / migrate-schema.controller.ts
97.23% 79.49% 100% 97.23%
🔴
... / types.ts
0% 0% 0% 0%
🟢
... / createProject.fixtures.ts
94.92% 77.78% 100% 94.92%
🟢
... / config.ts
100% 100% 100% 100%
🟢
... / index.ts
100% 100% 100% 100%
🔴
... / moduleLoader.ts
56% 40% 100% 56%
🟢
... / types.ts
100% 100% 100% 100%
🔴
... / utils.ts
0% 0% 0% 0%
🟢
... / networkFamily.ts
92.59% 88.89% 100% 92.59%
🟡
... / IPFSHTTPClientLite.ts
76.47% 80% 88.89% 76.47%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / utils.ts
92% 66.67% 100% 92%
🟡
... / admin.controller.ts
75.56% 96% 78.57% 75.56%
🟡
... / blockRange.ts
74.6% 100% 80% 74.6%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / blockchain.service.ts
100% 100% 100% 100%
🟢
... / SubqueryProject.ts
84.83% 50% 71.43% 84.83%
🟡
... / factory.ts
79.22% 66.67% 100% 79.22%
🟢
... / core.module.ts
100% 100% 100% 100%
🟢
... / dictionary.fixtures.ts
100% 100% 100% 100%
🟡
... / monitor.service.ts
70.04% 87.21% 94.12% 70.04%
🔴
... / sandbox.service.ts
33.33% 50% 25% 33.33%
🟡
... / baseCache.service.ts
67.57% 90.91% 66.67% 67.57%
🟡
... / baseStoreModel.service.ts
64.41% 83.33% 83.33% 64.41%
🟢
... / cacheable.ts
89.29% 75% 100% 89.29%
🟡
... / csvStore.ts
75% 73.68% 85.71% 75%
🟡
... / exporter.ts
71.67% 71.43% 71.43% 71.67%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / index.ts
100% 100% 100% 100%
🟡
... / cacheMetadata.ts
66.96% 78.57% 86.67% 66.96%
🟢
... / index.ts
100% 100% 100% 100%
🔴
... / metadata.ts
54.22% 71.43% 55.56% 54.22%
🟢
... / utils.ts
100% 100% 100% 100%
🟢
... / cacheModel.ts
88.86% 91.01% 90% 88.86%
🟢
... / index.ts
100% 100% 100% 100%
🟢
... / model.ts
81.01% 72% 90.91% 81.01%
🟢
... / utils.ts
100% 100% 100% 100%
🟡
... / cachePoi.ts
77.89% 89.47% 85.71% 77.89%
🟢
... / index.ts
100% 100% 100% 100%
🔴
... / poi.ts
41.96% 71.43% 44.44% 41.96%
🟢
... / setValueModel.ts
83.97% 77.14% 85.71% 83.97%
🟡
... / storeCache.service.ts
66.67% 75.76% 76.92% 66.67%
🟡
... / storeModel.service.ts
64.84% 61.54% 71.43% 64.84%
🟢
... / types.ts
100% 100% 100% 100%
🟢
... / utils.ts
93.33% 66.67% 100% 93.33%
🟢
... / worker.core.module.ts
100% 100% 0% 100%
🔴
... / worker.monitor.service.ts
39.53% 100% 0% 39.53%
🔴
... / meta.controller.ts
53.33% 100% 0% 53.33%
🟡
... / meta.module.ts
60% 100% 0% 60%
🟡
... / process.ts
61.29% 66.67% 40% 61.29%
🔴
... / foreceClean.init.ts
47.62% 100% 0% 47.62%
🔴
... / reindex.init.ts
33.33% 100% 0% 33.33%
🟢
... / testing.core.module.ts
100% 100% 100% 100%
🟡
... / autoQueue.ts
65.85% 87.18% 73.33% 65.85%
🟢
... / index.ts
100% 100% 100% 100%
🔴
... / queue.ts
47.22% 80% 66.67% 47.22%
🟡
... / rampQueue.ts
78.72% 91.3% 87.5% 78.72%
🟢
... / string.ts
100% 95.45% 100% 100%
🟡
... / blockchain.service.ts
63.68% 100% 42.86% 63.68%
🔴
... / datasourceProcessors.ts
0% 0% 0% 0%
🔴
... / index.ts
0% 0% 0% 0%
🔴
... / types.ts
0% 0% 0% 0%
🔴
... / networking.ts
31.58% 100% 0% 31.58%
Show files with reduced coverage 🔻
St.
File Statements Branches Functions Lines
🔴
... / delete.ts
48.72% (-5.57% 🔻)
100% 0%
48.72% (-5.57% 🔻)
🔴
... / promote.ts
44.19% (-4.53% 🔻)
100% 0%
44.19% (-4.53% 🔻)
🟡
... / add.ts
61.29% (-0.78% 🔻)
100% 0%
61.29% (-0.78% 🔻)
🟢
... / publish.ts
83.72% (-5.61% 🔻)
57.14% 100%
83.72% (-5.61% 🔻)
🔴
... / add-chain-controller.ts
39.85% (-0.23% 🔻)
66.67% 30%
39.85% (-0.23% 🔻)
🟢
... / build-controller.ts
86.03% (-5.27% 🔻)
57.14% 100%
86.03% (-5.27% 🔻)
🟢
... / codegen-controller.ts
88.77% (-0.62% 🔻)
82.67% (+7.09% 🔼)
100%
88.77% (-0.62% 🔻)
🟡
... / deploy-controller.ts
64.94% (+27.48% 🔼)
72.73% (-5.05% 🔻)
64.29% (+39.29% 🔼)
64.94% (+27.48% 🔼)
🟢
... / generate-controller.ts
97.75% (+0.1% 🔼)
93.24% (-0.79% 🔻)
100%
97.75% (+0.1% 🔼)
🟡
... / init-controller.ts
76.21% (+5.73% 🔼)
63.64% (-4.36% 🔻)
61.11% (+7.78% 🔼)
76.21% (+5.73% 🔼)
🟢
... / project-controller.ts
83.13% (-14.13% 🔻)
42.86% (-17.14% 🔻)
75% (-25% 🔻)
83.13% (-14.13% 🔻)
🟢
... / publish-controller.ts
82.63% (+2.38% 🔼)
70.27% (-0.84% 🔻)
100%
82.63% (+2.38% 🔼)
🔴
... / models.ts
54.44% (-45% 🔻)
81.25% (-11.06% 🔻)
30.77% (-69.23% 🔻)
54.44% (-45% 🔻)
🟢
... / ProjectManifestVersioned.ts
82.19% (-2.74% 🔻)
88.89% (-11.11% 🔻)
61.54% (+3.21% 🔼)
82.19% (-2.74% 🔻)
🟢
... / model.ts
93.14% (-4.57% 🔻)
92% (-8% 🔻)
73.33% (+1.9% 🔼)
93.14% (-4.57% 🔻)
🔴
... / models.ts
52.94% (-47.06% 🔻)
100%
0% (-100% 🔻)
52.94% (-47.06% 🔻)
🟡
... / load.ts
64.29% (+5.1% 🔼)
38.89% (-16.67% 🔻)
83.33% (+16.67% 🔼)
64.29% (+5.1% 🔼)
🟡
... / github-reader.ts
67.24% (-22.04% 🔻)
85.71% (+10.71% 🔼)
71.43% (-11.9% 🔻)
67.24% (-22.04% 🔻)
🟡
... / ipfs-reader.ts
66.67% (-19.05% 🔻)
91.67% (+28.03% 🔼)
71.43% (-11.9% 🔻)
66.67% (-19.05% 🔻)
🟡
... / local-reader.ts
72.09% (-13.95% 🔻)
100% (+37.5% 🔼)
83.33% (-16.67% 🔻)
72.09% (-13.95% 🔻)
🔴
... / base.ts
47.66% (-50.34% 🔻)
87.5% (-12.5% 🔻)
40% (-40% 🔻)
47.66% (-50.34% 🔻)
🔴
... / models.ts
31.74% (-68.26% 🔻)
100%
0% (-100% 🔻)
31.74% (-68.26% 🔻)
🟢
... / NodeConfig.ts
88.57% (-0.04% 🔻)
80.3% (+0.67% 🔼)
83.33% (-2.71% 🔻)
88.57% (-0.04% 🔻)
🟢
... / ProjectUpgrade.service.ts
82.63% (-4.45% 🔻)
91.58% (+0.22% 🔼)
92.31% (+1% 🔼)
82.63% (-4.45% 🔻)
🟢
... / configure.module.ts
82.67% (-1.9% 🔻)
73.08% (+9.08% 🔼)
100%
82.67% (-1.9% 🔻)
🟢
... / db.module.ts
89.63% (+1.35% 🔼)
62.5% (-20.83% 🔻)
80%
89.63% (+1.35% 🔼)
🟢
... / SchemaMigration.service.ts
84.57% (-2.99% 🔻)
81.82% (+0.57% 🔼)
83.33% (-16.67% 🔻)
84.57% (-2.99% 🔻)
🟡
... / migration-helpers.ts
74.54% (-1.48% 🔻)
86.76% (+6.17% 🔼)
90.91%
74.54% (-1.48% 🔻)
🟡
... / migration.ts
73.39% (-8.89% 🔻)
83.33% (+3.6% 🔼)
85% (-5.48% 🔻)
73.39% (-8.89% 🔻)
🟡
... / StoreOperations.ts
67.06% (-25.25% 🔻)
60% (-25% 🔻)
87.5% (-12.5% 🔻)
67.06% (-25.25% 🔻)
🔴
... / benchmark.service.ts
44.76% (-10.49% 🔻)
66.67%
36.36% (-3.64% 🔻)
44.76% (-10.49% 🔻)
🔴
... / base-block-dispatcher.ts
17.61% (-29.74% 🔻)
100%
4.55% (-5.45% 🔻)
17.61% (-29.74% 🔻)
🔴
... / block-dispatcher.ts
31.02% (-9.97% 🔻)
66.67% 28.57%
31.02% (-9.97% 🔻)
🔴
... / worker-block-dispatcher.ts
18.55% (-31.66% 🔻)
100%
0% (-27.27% 🔻)
18.55% (-31.66% 🔻)
🔴
... / coreDictionary.ts
48.72% (-51.28% 🔻)
87.5% (-6.94% 🔻)
77.78% (-22.22% 🔻)
48.72% (-51.28% 🔻)
🟡
... / dictionary.service.ts
68.97% (-16.18% 🔻)
83.78% (-1.93% 🔻)
83.33% (-7.58% 🔻)
68.97% (-16.18% 🔻)
🟡
... / dictionaryV1.ts
77.55% (-15.68% 🔻)
76.6% (-1.67% 🔻)
91.67% (-8.33% 🔻)
77.55% (-15.68% 🔻)
🟡
... / dictionaryV2.ts
70.62% (-11.06% 🔻)
68% (+2.78% 🔼)
88.89% (-11.11% 🔻)
70.62% (-11.06% 🔻)
🔴
... / ds-processor.service.ts
33.93% (-28.16% 🔻)
73.33% (-1.67% 🔻)
58.33% (-29.17% 🔻)
33.93% (-28.16% 🔻)
🟡
... / dynamic-ds.service.ts
63.38% (-26.82% 🔻)
63.64% (-3.03% 🔻)
81.82% (-3.9% 🔻)
63.38% (-26.82% 🔻)
🟢
... / fetch.service.ts
92.76% (+0.48% 🔼)
90.28% (+1.55% 🔼)
84.62% (-2.34% 🔻)
92.76% (+0.48% 🔼)
🟢
... / inMemoryCache.service.ts
86.21% (-13.79% 🔻)
100%
75% (-25% 🔻)
86.21% (-13.79% 🔻)
🔴
... / indexer.manager.ts
17.73% (-15.48% 🔻)
100%
10% (-2.5% 🔻)
17.73% (-15.48% 🔻)
🟢
... / PoiBlock.ts
84.68% (-13.71% 🔻)
96.55%
75% (-25% 🔻)
84.68% (-13.71% 🔻)
🔴
... / poi.service.ts
55.7% (+31.78% 🔼)
57.69% (-42.31% 🔻)
80% (+51.43% 🔼)
55.7% (+31.78% 🔼)
🔴
... / poiSync.service.ts
55.88% (-31% 🔻)
77.61% (+1.05% 🔼)
88.89% (-3.42% 🔻)
55.88% (-31% 🔻)
🟡
... / project.service.ts
74.42% (-5.58% 🔻)
72% (+1.82% 🔼)
85.19% (+1.19% 🔼)
74.42% (-5.58% 🔻)
🔴
... / sandbox.ts
59.73% (-8.25% 🔻)
56.25% (-0.89% 🔻)
57.14% (-4.4% 🔻)
59.73% (-8.25% 🔻)
🟡
... / store.service.ts
60.34% (-5.71% 🔻)
73.77% (+5.35% 🔼)
80.65% (+23.5% 🔼)
60.34% (-5.71% 🔻)
🔴
... / entity.ts
53.57% (-7.97% 🔻)
100%
50% (+50% 🔼)
53.57% (-7.97% 🔻)
🔴
... / store.ts
31.03% (-1.17% 🔻)
62.5% (-37.5% 🔻)
33.33% (+33.33% 🔼)
31.03% (-1.17% 🔻)
🟢
... / test.runner.ts
95.06% (-4.27% 🔻)
77.78% (+4.44% 🔼)
75% (-25% 🔻)
95.06% (-4.27% 🔻)
🔴
... / testing.service.ts
11.54% (-17.03% 🔻)
100% 0%
11.54% (-17.03% 🔻)
🔴
... / unfinalizedBlocks.service.ts
58.28% (-25.71% 🔻)
72.55% (-24.17% 🔻)
91.3% (-0.36% 🔻)
58.28% (-25.71% 🔻)
🟡
... / worker.builder.ts
61.97% (-17.22% 🔻)
65.38% 80%
61.97% (-17.22% 🔻)
🔴
... / worker.cache.service.ts
48.78% (-9.76% 🔻)
100% 0%
48.78% (-9.76% 🔻)
🔴
... / worker.connectionPoolState.manager.ts
38.21% (-22.76% 🔻)
100% 0%
38.21% (-22.76% 🔻)
🔴
... / worker.dynamic-ds.service.ts
44.44% (-17.78% 🔻)
100% 0%
44.44% (-17.78% 🔻)
🔴
... / worker.service.ts
21.24% (-23.4% 🔻)
100% 0%
21.24% (-23.4% 🔻)
🔴
... / worker.ts
41.75% (-0.71% 🔻)
100% 0%
41.75% (-0.71% 🔻)
🔴
... / worker.unfinalizedBlocks.service.ts
26.79% (-73.21% 🔻)
100%
0% (-100% 🔻)
26.79% (-73.21% 🔻)
🔴
... / logger.ts
49.3% (-15.18% 🔻)
33.33%
40% (+20% 🔼)
49.3% (-15.18% 🔻)
🔴
... / event.listener.ts
16.16% (-64.65% 🔻)
100%
0% (-25% 🔻)
16.16% (-64.65% 🔻)
🔴
... / health.controller.ts
37.93% (-17.24% 🔻)
100%
0% (-50% 🔻)
37.93% (-17.24% 🔻)
🔴
... / health.service.ts
21.05% (-36.48% 🔻)
100%
0% (-20% 🔻)
21.05% (-36.48% 🔻)
🔴
... / meta.service.ts
35.19% (-34.34% 🔻)
100% (+20% 🔼)
0% (-40% 🔻)
35.19% (-34.34% 🔻)
🔴
... / ready.controller.ts
34.78% (-21.74% 🔻)
100%
0% (-50% 🔻)
34.78% (-21.74% 🔻)
🔴
... / ready.service.ts
37.5% (-54.17% 🔻)
100%
0% (-66.67% 🔻)
37.5% (-54.17% 🔻)
🔴
... / forceClean.service.ts
21.05% (-5.26% 🔻)
100% 0%
21.05% (-5.26% 🔻)
🔴
... / reindex.service.ts
19.05% (-14.29% 🔻)
100% 0%
19.05% (-14.29% 🔻)
🟡
... / blocks.ts
71.21% (-28.79% 🔻)
91.67% (+2.78% 🔼)
75% (-25% 🔻)
71.21% (-28.79% 🔻)
🟡
... / project.ts
64.54% (-8.84% 🔻)
57.41% (-17.17% 🔻)
77.78%
64.54% (-8.84% 🔻)
🟢
... / promise.ts
88.14% (-3.63% 🔻)
100% (+13.64% 🔼)
71.43% (-14.29% 🔻)
88.14% (-3.63% 🔻)
🟢
... / reindex.ts
82.05% (+48.01% 🔼)
14.29% (-85.71% 🔻)
100% (+100% 🔼)
82.05% (+48.01% 🔼)
🔴
... / yargs.ts
43.38% (-2.11% 🔻)
100% 14.29%
43.38% (-2.11% 🔻)
🟢
... / SubqueryProject.ts
100% (+4.48% 🔼)
66.67% (-15.69% 🔻)
100% (+14.29% 🔼)
100% (+4.48% 🔼)
🟢
... / api.service.ts
87.2% (+3.69% 🔼)
81.54% (+9.32% 🔼)
80.77% (-5.9% 🔻)
87.2% (+3.69% 🔼)
🟡
... / apiPromise.connection.ts
78.13% (+9.05% 🔼)
54.55% (-25.45% 🔻)
66.67% (+23.81% 🔼)
78.13% (+9.05% 🔼)
🔴
... / index.ts
0% (-100% 🔻)
0% (-100% 🔻)
0% (-100% 🔻)
0% (-100% 🔻)
🟢
... / substrateDictionary.service.ts
98.15% (+7.58% 🔼)
66.67% (-6.06% 🔻)
100% (+20% 🔼)
98.15% (+7.58% 🔼)
🔴
... / types.ts
0% (-100% 🔻)
0% (-100% 🔻)
0% (-100% 🔻)
0% (-100% 🔻)
🟢
... / substrateDictionaryV1.ts
85.43% (-0.05% 🔻)
78.72% (+8.96% 🔼)
84.62% (+1.28% 🔼)
85.43% (-0.05% 🔻)
🟡
... / substrateDictionaryV2.ts
73.03% (-2.48% 🔻)
75% 33.33%
73.03% (-2.48% 🔻)
🔴
... / indexer.manager.ts
47.96% (-9.58% 🔻)
100%
16.67% (+7.58% 🔼)
47.96% (-9.58% 🔻)
🟢
... / runtimeService.ts
95.29% (+3.09% 🔼)
83.33% (-5.56% 🔻)
100% (+20% 🔼)
95.29% (+3.09% 🔼)
🟡
... / types.ts
70.45% (-14.84% 🔻)
100% 0%
70.45% (-14.84% 🔻)
🔴
... / http.ts
51.74% (-28.19% 🔻)
69.23% (+29.23% 🔼)
42.86% (+12.09% 🔼)
51.74% (-28.19% 🔻)
🟢
... / project.ts
88.73% (-0.16% 🔻)
68.18% 87.5%
88.73% (-0.16% 🔻)
🟢
... / buffer.ts
95.12% (-4.88% 🔻)
95.83% (-4.17% 🔻)
90.48% (+6.27% 🔼)
95.12% (-4.88% 🔻)
🟢
... / builder.ts
93.02% (+0.25% 🔼)
82.14% (-0.62% 🔻)
100%
93.02% (+0.25% 🔼)
🟡
... / logger.ts
70.35% (+0.75% 🔼)
51.85% (-3.15% 🔻)
78.57% (+3.57% 🔼)
70.35% (+0.75% 🔼)

Test suite run success

603 tests passing in 107 suites.

Report generated by 🧪jest coverage report action from 4eb01ba

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant