test: add test for sorts inside aggregate functions

substrait-io · Jul 4, 2024 · 61a61ca · 61a61ca
1 parent 48b75e1
commit 61a61ca
Showing 1 changed file with 6 additions and 0 deletions.
diff --git a/core/src/test/java/io/substrait/type/proto/AggregateRoundtripTest.java b/core/src/test/java/io/substrait/type/proto/AggregateRoundtripTest.java
@@ -32,6 +32,11 @@ private void assertAggregateRoundtrip(Expression.AggregationInvocation invocatio
             .initialSchema(NamedStruct.of(Arrays.asList("decimal"), R.struct(R.decimal(10, 2))))
             .addRows(literal)
             .build();
+    var sort =
+        ImmutableExpression.SortField.builder()
+            .expr(ExpressionCreator.bool(true, true))
+            .direction(Expression.SortDirection.DESC_NULLS_LAST)
+            .build();
     ExtensionCollector functionCollector = new ExtensionCollector();
     var to = new RelProtoConverter(functionCollector);
     var extensions = defaultExtensionCollection;
@@ -45,6 +50,7 @@ private void assertAggregateRoundtrip(Expression.AggregationInvocation invocatio
                     .declaration(extensions.aggregateFunctions().get(0))
                     .outputType(TypeCreator.of(false).I64)
                     .aggregationPhase(Expression.AggregationPhase.INITIAL_TO_RESULT)
+                    .sort(Arrays.asList(sort))
                     .invocation(invocation)
                     .build())
             .build();