Skip to content

Commit

Permalink
feat: uncomment tests
Browse files Browse the repository at this point in the history
Address PR feedback

Signed-off-by: andrew-coleman <[email protected]>
  • Loading branch information
andrew-coleman committed Jun 19, 2024
1 parent 157276e commit be74cd8
Showing 1 changed file with 11 additions and 8 deletions.
19 changes: 11 additions & 8 deletions spark/src/test/scala/io/substrait/spark/TPCHPlan.scala
Original file line number Diff line number Diff line change
Expand Up @@ -59,14 +59,11 @@ class TPCHPlan extends TPCHBase with SubstraitPlanTestBase {
assertSqlSubstraitRelRoundTrip(
"select l_partkey from lineitem where l_shipdate < date '1998-01-01' " +
"order by l_shipdate asc, l_discount desc")
// assertSqlSubstraitRelRoundTrip(
// "select l_partkey from lineitem where l_shipdate < date '1998-01-01' " +
// "order by l_shipdate asc, l_discount desc limit 100 offset 1000")
// assertSqlSubstraitRelRoundTrip(
// "select l_partkey from lineitem where l_shipdate < date '1998-01-01' " +
// "order by l_shipdate asc, l_discount desc limit 100")
// assertSqlSubstraitRelRoundTrip(
// "select l_partkey from lineitem where l_shipdate < date '1998-01-01' limit 100")
assertSqlSubstraitRelRoundTrip(
"select l_partkey from lineitem where l_shipdate < date '1998-01-01' " +
"order by l_shipdate asc, l_discount desc limit 100")
assertSqlSubstraitRelRoundTrip(
"select l_partkey from lineitem where l_shipdate < date '1998-01-01' limit 100")
assertSqlSubstraitRelRoundTrip(
"select l_partkey from lineitem where l_shipdate < date '1998-01-01' " +
"order by l_shipdate asc, l_discount desc nulls first")
Expand All @@ -75,6 +72,12 @@ class TPCHPlan extends TPCHBase with SubstraitPlanTestBase {
"order by l_shipdate asc, l_discount desc nulls last")
}

ignore("simpleOffsetClause") { // TODO need to implement the 'offset' clause for this to pass
assertSqlSubstraitRelRoundTrip(
"select l_partkey from lineitem where l_shipdate < date '1998-01-01' " +
"order by l_shipdate asc, l_discount desc limit 100 offset 1000")
}

test("simpleTest") {
val query = "select p_size from part where p_partkey > cast(100 as bigint)"
assertSqlSubstraitRelRoundTrip(query)
Expand Down

0 comments on commit be74cd8

Please sign in to comment.